Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitAndTools.hub: remove go compiler from runtime closure #42354

Merged
merged 1 commit into from
Jun 21, 2018
Merged

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jun 21, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gitAndTools.hub

Partial log (click to expand)

gzipping man pages under /nix/store/p79igkcsjzr2xd94g37k6qw64milynr5-hub-2.4.0-bin/share/man/
strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/p79igkcsjzr2xd94g37k6qw64milynr5-hub-2.4.0-bin/bin
patching script interpreter paths in /nix/store/p79igkcsjzr2xd94g37k6qw64milynr5-hub-2.4.0-bin
checking for references to /build in /nix/store/p79igkcsjzr2xd94g37k6qw64milynr5-hub-2.4.0-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/8rd4whzfgzzs9i2vpv2l9amd4hwfmc6q-hub-2.4.0
strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/8rd4whzfgzzs9i2vpv2l9amd4hwfmc6q-hub-2.4.0
checking for references to /build in /nix/store/8rd4whzfgzzs9i2vpv2l9amd4hwfmc6q-hub-2.4.0...
/nix/store/p79igkcsjzr2xd94g37k6qw64milynr5-hub-2.4.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gitAndTools.hub

Partial log (click to expand)

groff -Wall -mtty-char -mandoc -Tutf8 -rLL=87n share/man/man1/hub-remote.1.ronn | col -b >share/man/man1/hub-remote.1.txt
groff -Wall -mtty-char -mandoc -Tutf8 -rLL=87n share/man/man1/hub-submodule.1.ronn | col -b >share/man/man1/hub-submodule.1.txt
post-installation fixup
gzipping man pages under /nix/store/1la8clvk2lns7spclxsbxrx3gxkd5zjd-hub-2.4.0-bin/share/man/
strip is /nix/store/8q05v40n0f7amgw70pk6bkb23r7hrzgn-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/1la8clvk2lns7spclxsbxrx3gxkd5zjd-hub-2.4.0-bin/bin
patching script interpreter paths in /nix/store/1la8clvk2lns7spclxsbxrx3gxkd5zjd-hub-2.4.0-bin
strip is /nix/store/8q05v40n0f7amgw70pk6bkb23r7hrzgn-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/iz5yg6vkl7y3ashh6q2n8yyqf2aryxwi-hub-2.4.0
/nix/store/1la8clvk2lns7spclxsbxrx3gxkd5zjd-hub-2.4.0-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gitAndTools.hub

Partial log (click to expand)

gzipping man pages under /nix/store/8rbsrv1bgm61rm414bl4rznr1gssrv40-hub-2.4.0-bin/share/man/
strip is /nix/store/min150lkigznaayzpwvf8d4jdl1dqvx6-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8rbsrv1bgm61rm414bl4rznr1gssrv40-hub-2.4.0-bin/bin
patching script interpreter paths in /nix/store/8rbsrv1bgm61rm414bl4rznr1gssrv40-hub-2.4.0-bin
checking for references to /build in /nix/store/8rbsrv1bgm61rm414bl4rznr1gssrv40-hub-2.4.0-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/cknsbll9z1hm7rajnibrg1shg8xc6ic9-hub-2.4.0
strip is /nix/store/min150lkigznaayzpwvf8d4jdl1dqvx6-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/cknsbll9z1hm7rajnibrg1shg8xc6ic9-hub-2.4.0
checking for references to /build in /nix/store/cknsbll9z1hm7rajnibrg1shg8xc6ic9-hub-2.4.0...
/nix/store/8rbsrv1bgm61rm414bl4rznr1gssrv40-hub-2.4.0-bin

@Mic92 Mic92 merged commit 4756e6f into NixOS:master Jun 21, 2018
@Mic92 Mic92 deleted the hub branch June 21, 2018 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants