vlc: 3.0.3 -> 3.0.4

[coreyoconnor]

Motivation for this change

• vlc 3.0.3 does not compile due to missing vlc-qt5.11.patch
• update

Both patches appear unnecessary now.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Fits CONTRIBUTING.md.

---

[GrahamcOfBorg]

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: vlc

Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

[GrahamcOfBorg]

Failure on aarch64-linux (full log)

Attempted: vlc

Partial log (click to expand)

g++: error: unrecognized command line option '-m64'
make[1]: *** [Makefile:32: Media.o] Error 1
make[1]: Leaving directory '/build/live/liveMedia'
make: *** [Makefile:33: all] Error 2
builder for '/nix/store/h418wwalkqzw97jd3rsfqzv27c38z8fl-live555-2018.02.28.drv' failed with exit code 2
copying path '/nix/store/a7zf6hzv4am9dar25mxsy71196ir6wsp-samba-4.7.9-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/1ipr93n66mkp666khnnkfc5kmxh6y2dy-ffmpeg-3.4.4-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/ii63767j4m2mszmp0bl6k1v3p51rc8hd-ffmpeg-3.4.4-dev' from 'https://cache.nixos.org'...
cannot build derivation '/nix/store/pmlyvyry85cvlvsbhsmzd824hdk0bx0x-vlc-3.0.4.drv': 1 dependencies couldn't be built
error: build of '/nix/store/pmlyvyry85cvlvsbhsmzd824hdk0bx0x-vlc-3.0.4.drv' failed

[xeji]

aarch64 failure is unrelated, live555 has been broken on aarch64 for a while

[GrahamcOfBorg]

Success on x86_64-linux (full log)

Attempted: vlc

Partial log (click to expand)

/nix/store/na110kx59n7hbbs4xrjnpb2y9yaz4mdb-vlc-3.0.4/share/vlc/utils/audio-vlc-default.sh: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/na110kx59n7hbbs4xrjnpb2y9yaz4mdb-vlc-3.0.4/share/vlc/utils/gnome-vlc-default.sh: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/na110kx59n7hbbs4xrjnpb2y9yaz4mdb-vlc-3.0.4/share/vlc/utils/video-vlc-default.sh: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/na110kx59n7hbbs4xrjnpb2y9yaz4mdb-vlc-3.0.4/bin/nvlc: interpreter directive changed from " /bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/na110kx59n7hbbs4xrjnpb2y9yaz4mdb-vlc-3.0.4/bin/cvlc: interpreter directive changed from " /bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/na110kx59n7hbbs4xrjnpb2y9yaz4mdb-vlc-3.0.4/bin/rvlc: interpreter directive changed from " /bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/na110kx59n7hbbs4xrjnpb2y9yaz4mdb-vlc-3.0.4/bin/qvlc: interpreter directive changed from " /bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/na110kx59n7hbbs4xrjnpb2y9yaz4mdb-vlc-3.0.4...
postPatchMkspecs
/nix/store/na110kx59n7hbbs4xrjnpb2y9yaz4mdb-vlc-3.0.4

[xeji]

Works for me

[xeji]

backported to 18.09 because of broken patch url: d26e830