Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintainers/maintainer-list.nix: add PGP/GPG fingerprints #47663

Merged
merged 4 commits into from
Jan 21, 2019

Conversation

oxij
Copy link
Member

@oxij oxij commented Oct 2, 2018

Motivation for this change

A first tiny step towards NixOS/rfcs#34

Things done
  • It evaluates.

What is a "real name" anyway? Are we in the buisness of checking passports here?
@zimbatm
Copy link
Member

zimbatm commented Oct 2, 2018

Mine is rsa2048/0x71BAF6D40C1D63D7 and 2603 53B9 93F8 CE16 752E F48C 71BA F6D4 0C1D 63D7 and

@oxij
Copy link
Member Author

oxij commented Oct 2, 2018

Hm, do you want to include the key type there too? It might be useful, if just for statistics.

@zimbatm
Copy link
Member

zimbatm commented Oct 2, 2018

Actually the short ID is considered insecure so we might as well drop it (I think it's still too easy to generate collisions)

@zimbatm
Copy link
Member

zimbatm commented Oct 2, 2018

That would also allow to simplify the instruction to gpg --fingerprint <email>

@tilpner
Copy link
Member

tilpner commented Oct 2, 2018

Should there be support for multiple fingerprints per person? (I have multiple, but I admit to not always following best practices)

@oxij
Copy link
Member Author

oxij commented Oct 2, 2018

@zimbatm Yes, but it is useful for fetching keys from keyservers.

@tilpner Do both keys have the same email? Should we also support multiple emails then?

@tilpner
Copy link
Member

tilpner commented Oct 2, 2018

@oxij That's correct, they all have the same name and email. I currently have three signing subkeys, one for each device I sign things from. My motivation was to be able to revoke a single device on compromise, instead of having to re-do all of them.

```
and then run `gpg -k`.

!!! Note that PGP/GPG values stored here are for informational purposes only, don't use this file as a singe source of truth.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to check keys against the github API?

Copy link
Member

@tilpner tilpner Oct 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is https://api.github.com/users/tilpner/gpg_keys in the v3 API. This might indeed be useable for the initial population of this list

Edit: Unfortunately, it seems GH processes the public key into some other format. I have no idea how to convert it back into something gpg can handle

@oxij oxij force-pushed the maintainers/gpg-fingerprint branch from b8e78b6 to 1e58ddc Compare October 3, 2018 00:19
@oxij oxij force-pushed the maintainers/gpg-fingerprint branch from 1e58ddc to 419ea86 Compare October 3, 2018 00:22
@oxij
Copy link
Member Author

oxij commented Oct 3, 2018

See the new version.

@oxij
Copy link
Member Author

oxij commented Oct 3, 2018

@tilpner if you use per device subkeys AFAIK you can specify the fingerprint and id of the master key. But multiple keys should be useful anyway, e.g. when expiring a key.

@oxij
Copy link
Member Author

oxij commented Oct 5, 2018 via email

github = "GithubUsername";
keys = [{
longkeyid = "rsa2048/0x0123456789ABCDEF";
fingerprint = "AAAA BBBB CCCC DDDD EEEE FFFF 0000 1111 2222 3333";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's getting complicated but how about adding an expiry date for the key? That way if there are multiple listed it makes it clearer which one is only there for historical reason (and that no new stuff should be signed with it).

@oxij
Copy link
Member Author

oxij commented Oct 5, 2018 via email

gpg --keyid-format 0xlong --fingerprint <email> | head -n 2
```

!!! Note that PGP/GPG values stored here are for informational purposes only, don't use this file as a source of truth.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably self-evident, but maybe stipulate that the commit that adds a key be signed by that key?

@7c6f434c
Copy link
Member

@joachifm Not sure for multi-device setups: maybe adding multiple keys can be signed by just one of them?

@oxij should I merge it as-is today? I don't see any objections or drawbacks.

@zimbatm
Copy link
Member

zimbatm commented Jan 21, 2019

/cc @grahamc

@Mic92 Mic92 merged commit 0ad9ad4 into NixOS:master Jan 21, 2019
@ghost ghost mentioned this pull request Jan 21, 2019
10 tasks
@oxij
Copy link
Member Author

oxij commented Jan 23, 2019 via email

@oxij oxij deleted the maintainers/gpg-fingerprint branch August 12, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants