retdec: 3.0 -> 3.2

[timokau]

Motivation for this change

retdec has been outdated for a while. That is probably because it is a pain to upgrade. I've opened avast/retdec#412 for that.

What I've ended up with here won't win any beauty contests, but it is the best I could do. @dtzWill what do you think?

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Fits CONTRIBUTING.md.

---

[GrahamcOfBorg]

Failure on x86_64-darwin (full log)

Attempted: retdec

Partial log (click to expand)

Try 'libtool --help' for more information.
libtool:   error: unrecognised option: '-static'
make[5]: *** [lib/Support/CMakeFiles/LLVMSupport.dir/build.make:1495: lib/libLLVMSupport.a] Error 1
make[4]: *** [CMakeFiles/Makefile2:124: lib/Support/CMakeFiles/LLVMSupport.dir/all] Error 2
make[3]: *** [Makefile:106: all] Error 2
make[2]: *** [deps/llvm/CMakeFiles/llvm-project.dir/build.make:113: external/src/llvm-project-stamp/llvm-project-build] Error 2
make[1]: *** [CMakeFiles/Makefile2:258: deps/llvm/CMakeFiles/llvm-project.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
builder for '/nix/store/0717dnhxhj4mj5007k5i85mzc6id7qi8-retdec-3.2.drv' failed with exit code 2
error: build of '/nix/store/0717dnhxhj4mj5007k5i85mzc6id7qi8-retdec-3.2.drv' failed

[GrahamcOfBorg]

Failure on aarch64-linux (full log)

Attempted: retdec

Partial log (click to expand)

[  FAILED  ] ByteValueStorageTests.Get10ByteWorks (0 ms)
[  PASSED  ] 349 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] ByteValueStorageTests.Get10ByteWorks
 1 FAILED TEST
FAILED (return code 1)

warning: module 'colorama' (https://pypi.python.org/pypi/colorama) not found, running without color support
builder for '/nix/store/dvpfhgk4mh1sd6jvivc1q0rm9jav7sy3-retdec-3.2.drv' failed with exit code 1
error: build of '/nix/store/dvpfhgk4mh1sd6jvivc1q0rm9jav7sy3-retdec-3.2.drv' failed

[GrahamcOfBorg]

Timed out, unknown build status on x86_64-linux (full log)

Attempted: retdec

Partial log (click to expand)

[ 53%] Linking CXX static library libretdec-dwarfparser.a
[ 53%] Built target retdec-dwarfparser
Scanning dependencies of target retdec-rtti-finder
[ 53%] Building CXX object src/rtti-finder/CMakeFiles/retdec-rtti-finder.dir/rtti/rtti_gcc_parser.cpp.o
[ 53%] Building CXX object src/rtti-finder/CMakeFiles/retdec-rtti-finder.dir/rtti/rtti_msvc_parser.cpp.o
[ 53%] Building CXX object src/llvmir2hll/CMakeFiles/retdec-llvmir2hll.dir/optimizer/optimizers/dead_code_optimizer.cpp.o
[ 54%] Building CXX object src/rtti-finder/CMakeFiles/retdec-rtti-finder.dir/vtable/vtable_finder.cpp.o
[ 54%] Building CXX object src/llvmir2hll/CMakeFiles/retdec-llvmir2hll.dir/optimizer/optimizers/dead_local_assign_optimizer.cpp.o
building of '/nix/store/vwf4xmsw23rm5s8cqcxcf0r9vz6x9xcy-retdec-3.2.drv' timed out after 1800 seconds
error: build of '/nix/store/vwf4xmsw23rm5s8cqcxcf0r9vz6x9xcy-retdec-3.2.drv' failed

[GrahamcOfBorg]

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: retdec

Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

[GrahamcOfBorg]

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: retdec

Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

[GrahamcOfBorg]

Timed out, unknown build status on x86_64-linux (full log)

Attempted: retdec

Partial log (click to expand)

[ 45%] Built target retdec-dwarfparser
Scanning dependencies of target retdec-loader
[ 45%] Building CXX object src/loader/CMakeFiles/retdec-loader.dir/utils/range.cpp.o
[ 46%] Building CXX object src/loader/CMakeFiles/retdec-loader.dir/utils/overlap_resolver.cpp.o
[ 46%] Building CXX object src/loader/CMakeFiles/retdec-loader.dir/utils/name_generator.cpp.o
[ 46%] Building CXX object src/loader/CMakeFiles/retdec-loader.dir/image_factory.cpp.o
[ 46%] Building CXX object src/llvmir2hll/CMakeFiles/retdec-llvmir2hll.dir/llvm/llvmir2bir_converters/new_llvmir2bir_converter/llvm_type_converter.cpp.o
[ 46%] Building CXX object src/loader/CMakeFiles/retdec-loader.dir/loader/pe/pe_image.cpp.o
building of '/nix/store/vwf4xmsw23rm5s8cqcxcf0r9vz6x9xcy-retdec-3.2.drv' timed out after 1800 seconds
error: build of '/nix/store/vwf4xmsw23rm5s8cqcxcf0r9vz6x9xcy-retdec-3.2.drv' failed

[dtzWill]

It builds for me!!! Haha for something like this that itself is quite the victory :).

Various minor comments but overall looks good! Just small cleanup I think.

I haven't tested the variant with PE patterns, I admit 😇.

[timokau]

I removed the two debugging comments, so if you have no further suggestions this should be good to go. Thank you for the review :)

[GrahamcOfBorg]

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: retdec

Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

[GrahamcOfBorg]

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: retdec

Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

[dtzWill]

Great, thanks for tackling this!

[GrahamcOfBorg]

Success on x86_64-linux (full log)

Attempted: retdec

Partial log (click to expand)

retdec-tests-loader
[  PASSED  ] 65 tests.

retdec-tests-unpacker
[  PASSED  ] 68 tests.

retdec-tests-utils
[  PASSED  ] 350 tests.
warning: module 'colorama' (https://pypi.python.org/pypi/colorama) not found, running without color support
/nix/store/19ac1lp618yw5y9wx5c0yz2yi4p8bqcf-retdec-3.2