-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nodejs-10_x to 10.13.0 #49453
Conversation
@GrahamcOfBorg build nodejs-10_x |
Failure on aarch64-linux (full log) Attempted: nodejs-10_x Partial log (click to expand)
|
Timed out, unknown build status on x86_64-darwin (full log) Attempted: nodejs-10_x Partial log (click to expand)
|
Timed out, unknown build status on x86_64-linux (full log) Attempted: nodejs-10_x Partial log (click to expand)
|
So... this seems to be an equal result of OfBorg CI as in the last bump of nodejs v10 (#48186). As you seem to regularly work on keeping our I just compiled NodeJS 10.13 locally with sandbox enabled and it seems to work ( |
Interesting. It looks similar to the build issues with nodejs 11 on NixOS x86_64 (see #48911). |
Thanks a lot for the cross-link 👍 I'll see if I can reproduce something like this on my machine, maybe this helps me to find the root cause. Otherwise I'd rather wait with merging (sorry!) and ping one of the folks in |
nodejs v10.14.2 released https://nodejs.org/en/blog/release/v10.14.2/ |
Superseded by #53270 |
Motivation for this change
Release Notes
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)