libtiff: 4.0.9 -> 2018-11-04

[andrew-d]

Motivation for this change

This includes a bunch of security fixes (#49786), and mimics what Debian has done in moving to a git snapshot instead of a released version + backported security patches.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Fits CONTRIBUTING.md.

---

(there don't appear to be any maintainers for libtiff to cc)

[Synthetica9]

https://nixos.org/nixpkgs/manual/#sec-package-naming

[Synthetica9]

Suggested change

	version = "2018-11-04";
	version = "unstable-2018-11-04";

[andrew-d]

Good point! Based on the guidelines, I put the unstable in the package name, not version, but 👍

[andrew-d]

@Synthetica9 - sorry for the ping, but anything I can do to help get this merged?

[Synthetica9]

I'm not a maintainer, but @xeji, could you have a look at this? (hope the ping works since I'm sending this via email)

…

On Sat, 10 Nov 2018, 10:36 Andrew Dunham, ***@***.***> wrote: @Synthetica9 <https://github.com/Synthetica9> - sorry for the ping, but anything I can do to help get this merged? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#49860 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGv3p-sJiNaixDm5e76mxDo1plPwQQ4jks5utp4zgaJpZM4YR5nG> .

[Mic92]

@GrahamcOfBorg build graphicsmagick

[GrahamcOfBorg]

Unexpected error: command failed with exit code 1 on x86_64-darwin (full log)

Attempted: graphicsmagick

Partial log (click to expand)

cannot build derivation '/nix/store/8y1xarz84imwanqk3k8vghdwfrp4pjln-absolute_gir_path.patch.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/ibfahkfyw95wwl7pdv6vvjs94y1w6h8g-harfbuzz-2.1.0.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/ccijrmks3l6pn8gnf188wkckz5zfmqwk-mesa-noglu-18.2.4.drv': 31 dependencies couldn't be built
cannot build derivation '/nix/store/v20nx6gf9k8j9jb19xl9f57797r66ip4-gobject-introspection-1.56.0.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/a09c2bqqb1drb18n1a60yw2kyq6hvq8x-libGL-1.0.0.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/0c16hab08mml05syqc89c5ixq2kgxkxx-libdevil-1.7.8.drv': 11 dependencies couldn't be built
cannot build derivation '/nix/store/7i8pd0qphriwpappra6j8imxyz25w380-pango-1.42.4.drv': 15 dependencies couldn't be built
cannot build derivation '/nix/store/pga20lhdbhz14rz11jz83fm638pb3pgm-graphviz-2.40.1.drv': 20 dependencies couldn't be built
cannot build derivation '/nix/store/39kpa0lhaqvzbifkwi0c3qkkxnb0snm0-graphicsmagick-1.3.30.drv': 12 dependencies couldn't be built
error: build of '/nix/store/39kpa0lhaqvzbifkwi0c3qkkxnb0snm0-graphicsmagick-1.3.30.drv' failed

[GrahamcOfBorg]

Success on aarch64-linux (full log)

Attempted: graphicsmagick

Partial log (click to expand)

shrinking /nix/store/r34ms9zr5v6l93n04h4sb82h5pm01hyc-graphicsmagick-1.3.30/lib/libGraphicsMagick.so.3.18.1
gzipping man pages under /nix/store/r34ms9zr5v6l93n04h4sb82h5pm01hyc-graphicsmagick-1.3.30/share/man/
strip is /nix/store/426i2d272x6c8j4shwl1377xj2cf1ijj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/r34ms9zr5v6l93n04h4sb82h5pm01hyc-graphicsmagick-1.3.30/lib  /nix/store/r34ms9zr5v6l93n04h4sb82h5pm01hyc-graphicsmagick-1.3.30/bin
patching script interpreter paths in /nix/store/r34ms9zr5v6l93n04h4sb82h5pm01hyc-graphicsmagick-1.3.30
/nix/store/r34ms9zr5v6l93n04h4sb82h5pm01hyc-graphicsmagick-1.3.30/bin/GraphicsMagickWand-config: interpreter directive changed from "/bin/sh" to "/nix/store/dsvsl7r2vqvjilphj8ci8skxkib89xsa-bash-4.4-p23/bin/sh"
/nix/store/r34ms9zr5v6l93n04h4sb82h5pm01hyc-graphicsmagick-1.3.30/bin/GraphicsMagick-config: interpreter directive changed from "/bin/sh" to "/nix/store/dsvsl7r2vqvjilphj8ci8skxkib89xsa-bash-4.4-p23/bin/sh"
/nix/store/r34ms9zr5v6l93n04h4sb82h5pm01hyc-graphicsmagick-1.3.30/bin/GraphicsMagick++-config: interpreter directive changed from "/bin/sh" to "/nix/store/dsvsl7r2vqvjilphj8ci8skxkib89xsa-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/r34ms9zr5v6l93n04h4sb82h5pm01hyc-graphicsmagick-1.3.30...
/nix/store/r34ms9zr5v6l93n04h4sb82h5pm01hyc-graphicsmagick-1.3.30

[GrahamcOfBorg]

Success on x86_64-linux (full log)

Attempted: graphicsmagick

Partial log (click to expand)

shrinking /nix/store/kh3pi565d5qcnv56ghqx9b1has0wprzn-graphicsmagick-1.3.30/bin/gm
gzipping man pages under /nix/store/kh3pi565d5qcnv56ghqx9b1has0wprzn-graphicsmagick-1.3.30/share/man/
strip is /nix/store/xzn29jrdk6czmx5qai15v6hwsrxviw4c-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/kh3pi565d5qcnv56ghqx9b1has0wprzn-graphicsmagick-1.3.30/lib  /nix/store/kh3pi565d5qcnv56ghqx9b1has0wprzn-graphicsmagick-1.3.30/bin
patching script interpreter paths in /nix/store/kh3pi565d5qcnv56ghqx9b1has0wprzn-graphicsmagick-1.3.30
/nix/store/kh3pi565d5qcnv56ghqx9b1has0wprzn-graphicsmagick-1.3.30/bin/GraphicsMagick-config: interpreter directive changed from "/bin/sh" to "/nix/store/bz05mnzgipkkcvlr3l6avvh659ck7zrf-bash-4.4-p23/bin/sh"
/nix/store/kh3pi565d5qcnv56ghqx9b1has0wprzn-graphicsmagick-1.3.30/bin/GraphicsMagickWand-config: interpreter directive changed from "/bin/sh" to "/nix/store/bz05mnzgipkkcvlr3l6avvh659ck7zrf-bash-4.4-p23/bin/sh"
/nix/store/kh3pi565d5qcnv56ghqx9b1has0wprzn-graphicsmagick-1.3.30/bin/GraphicsMagick++-config: interpreter directive changed from "/bin/sh" to "/nix/store/bz05mnzgipkkcvlr3l6avvh659ck7zrf-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/kh3pi565d5qcnv56ghqx9b1has0wprzn-graphicsmagick-1.3.30...
/nix/store/kh3pi565d5qcnv56ghqx9b1has0wprzn-graphicsmagick-1.3.30