-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trivial: tiny cleanups and fixes #49864
Conversation
oxij
commented
Nov 7, 2018
- Running with these applied.
fe3ddf6
to
43965b2
Compare
Success on x86_64-linux (full log) Attempted: espeak-ng, mesa Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: espeak-ng, mesa Partial log (click to expand)
|
@@ -18,7 +18,7 @@ | |||
## optional libraries | |||
|
|||
, alsaSupport ? stdenv.isLinux, alsaLib | |||
, pulseaudioSupport ? true, libpulseaudio | |||
, pulseaudioSupport ? stdenv.isLinux, libpulseaudio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message should be descriptive like "firefox: disable pulseaudio support on non-Linux by default"
nixos/release.nix
Outdated
@@ -108,7 +108,7 @@ let | |||
let | |||
configEvaled = import lib/eval-config.nix { | |||
inherit system; | |||
modules = [ module versionModule ]; | |||
modules = [ configuration module versionModule ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like [ configuration module versionModule ]
should be factored out across the entire file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Qt changes look fine to me.
43965b2
to
3902085
Compare
@roberth done. |
Also pushed a piece of #49862 here.
|
Success on x86_64-linux (full log) Attempted: espeak-ng, mesa Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: espeak-ng, gnuradio-rds, mesa Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: espeak-ng, mesa Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: espeak-ng, gnuradio-rds, mesa Partial log (click to expand)
|