-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
neovim wrapper: build with nodejs support #49884
Merged
Mic92
merged 2 commits into
NixOS:master
from
kalbasit:nixpkgs_neovim-build-with-nodejs
Nov 15, 2018
Merged
neovim wrapper: build with nodejs support #49884
Mic92
merged 2 commits into
NixOS:master
from
kalbasit:nixpkgs_neovim-build-with-nodejs
Nov 15, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalbasit
changed the title
Nixpkgs neovim build with nodejs
neovim wrapper: build with nodejs support
Nov 7, 2018
@GrahamcOfBorg build neovim |
Success on x86_64-linux (full log) Attempted: neovim Partial log (click to expand)
|
kalbasit
force-pushed
the
nixpkgs_neovim-build-with-nodejs
branch
from
November 7, 2018 20:49
58c2358
to
54a33ef
Compare
Failure on aarch64-linux (full log) Attempted: neovim Partial log (click to expand)
|
@GrahamcOfBorg build neovim |
Failure on aarch64-linux (full log) Attempted: neovim Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: neovim Partial log (click to expand)
|
not familiar with nodeJs but looks fine. |
kalbasit
force-pushed
the
nixpkgs_neovim-build-with-nodejs
branch
from
November 15, 2018 03:54
54a33ef
to
da4a004
Compare
I rebased this PR over the latest master, @Mic92 can I get a review on this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I use NeoVim to develop nodejs projects but my editor does not work well because it's missing the NodeJS neovim provider.
I have tested this by running
nix-shell -I nixpkgs=. --pure -p 'with import <nixpkgs> {}; neovim.override { withNodeJs=true; }' --run nvim
When I run
:checkhealth
, I see it reporting nodejs as functional.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)