Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncurses: upgrade from 6.1 -> 6.1-20181027 #51181

Merged
merged 1 commit into from
Dec 5, 2018

Conversation

guaraqe
Copy link

@guaraqe guaraqe commented Nov 28, 2018

Motivation for this change

Backporting from this PR: #49859
Needed as commented here: #49787

Original message

This includes fixes for CVE-2018-10754.

While we're changing things, also set the --with-manpage-format=normal
configure flag, which prevents the configure script from looking in
/usr to determine whether to compress manpages. This was already the
format on NixOS (where these directories don't exist), but making this
explicit makes the build more reproducible on other distros.

@c0bw3b c0bw3b added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Nov 28, 2018
@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 4, 2018

@guaraqe give the amount of packages that will need to be rebuilt, can you rebase and target this PR at the staging-18.09 branch?

This includes fixes for CVE-2018-10754.

While we're changing things, also set the `--with-manpage-format=normal`
configure flag, which prevents the `configure` script from looking in
/usr to determine whether to compress manpages. This was already the
format on NixOS (where these directories don't exist), but making this
explicit makes the build more reproducible on other distros.

(cherry picked from commit f485b2e)
@guaraqe guaraqe requested a review from FRidh as a code owner December 5, 2018 09:26
@guaraqe guaraqe changed the base branch from release-18.09 to staging-18.09 December 5, 2018 09:27
@guaraqe
Copy link
Author

guaraqe commented Dec 5, 2018

@c0bw3b Rebased and changed the target branch to staging-18.09.

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 5, 2018

@GrahamcOfBorg build ncurses6

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 5, 2018

Thanks for the contrib @guaraqe

@c0bw3b c0bw3b merged commit 261bf90 into NixOS:staging-18.09 Dec 5, 2018
@c0bw3b c0bw3b added the 8.has: port to stable A PR already has a backport to the stable release. label Dec 5, 2018
@guaraqe guaraqe deleted the ncurses branch December 5, 2018 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux: 501+
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants