konsole: fix arrow keys

[Synthetica9]

Motivation for this change

(partially?) fixes #29951

Couldn't get Yakuake to work, so haven't tested that.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Assured whether relevant documentation is up to date
• Fits CONTRIBUTING.md.

---

[Synthetica9]

CC @michaelpj @mbertolutti @qknight

[michaelpj]

Is this the right fix? If Konsole does indeed look in XDG_DATA_DIRS then it's just a matter of making sure all the relevant stuff gets linked into the profile, since that already goes in XDG_DATA_DIRS. But that's somewhat tricky, since currently we can only decide to link in subdirs of share in a module.

[Synthetica9]

I'm not 100% familiar with how KDE apps are built , I arrived at this fix by looking at the source for QT (my original intention was to patch that, but that didn't turn out to be needed). If there is a KDE- or QT-specific way to handle this sort of thing, I'm all ears. All I know is that this fix works (using it on my personal laptop: Synthetica9/configuration.nix@336cccf and I haven't encountered any problems yet)

…

On Mon, 3 Dec 2018, 15:41 Michael Peyton Jones, ***@***.***> wrote: Is this the right fix? If Konsole does indeed look in XDG_DATA_DIRS then it's just a matter of making sure all the relevant stuff gets linked into the profile, since that already goes in XDG_DATA_DIRS. But that's somewhat tricky, since currently we can only decide to link in subdirs of share in a module. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#51412 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGv3pwmoF1IwnwuJkuBWQe2yRc9dy47Rks5u1TgKgaJpZM4Y9pji> .

[michaelpj]

This will work for this issue, but e.g. if you add other programs that provide data files that konsole uses then it won't pick them up.

The usual mechanism for this is XDG_DATA_DIRS. You're adding the konsole /share output, which will make it pick up the stuff packaged with konsole, but other stuff needs to go in the system XDG_DATA_DIRS for konsole to find it. But if we had that working then we wouldn't need this at all, since the konsole /share files would be picked up in exactly the same way.

So why don't we pick them up? The answer is because we don't (usually) merge in all the subdirectories of /share. So we just ignore the ones that konsole needs. Normally you can only change that with a nixos module. The Plasma module, for example, does so.

Previously I've thought that was good, but increasingly I wonder if we should just link the whole of /share by default. (see #47173)

So I guess this is an okay solution, but we should be aware that konsole may still not work "properly" when you're not running Plasma.

[michaelpj]

The alternative solution would be to add a programs.konsole module.

[Synthetica9]

So I guess this is an okay solution, but we should be aware that konsole may still not work "properly" when you're not running Plasma.

I'm not running Plasma, so it's certainly not a strict requirement for this to work.

[michaelpj]

OOI, you say you couldn't make Yakuake work, but have you tried wrapping it so it has access to Konsole's data files? I think it uses a lot of the same code under the hood.

[ttuegel]

I'm not running Plasma, so it's certainly not a strict requirement for this to work.

I believe the way to fix this problem for all applications is to add this to your configuration.