Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome3.nautilus: fix thumbnail generation #51933

Merged
merged 1 commit into from
Dec 13, 2018
Merged

gnome3.nautilus: fix thumbnail generation #51933

merged 1 commit into from
Dec 13, 2018

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Dec 13, 2018

Motivation for this change

3.30 copied over the thumbnail code frome gnome-desktop:
https://gitlab.gnome.org/GNOME/nautilus/commit/673c81cf9f1d68b71041220e6e44624dee44dbfc

Simply patch nautilus too.

ref #50494

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hedning hedning requested a review from jtojnar December 13, 2018 08:18
@GrahamcOfBorg GrahamcOfBorg added 6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Dec 13, 2018
jtojnar
jtojnar reviewed Dec 13, 2018
View reviewed changes
pkgs/desktops/gnome-3/core/nautilus/default.nix Outdated

buildInputs = [
glib-networking shared-mime-info libexif gtk exempi libnotify libselinux
tracker tracker-miners gnome-desktop gexiv2 libseccomp
tracker tracker-miners gnome-desktop gexiv2 libseccomp bubblewrap
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gnome-desktop no longer seems to be necessary GNOME/nautilus@673c81c.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, duh :)

@hedning hedning force-pushed the fix-nautilus-thumbnails branch from 3493ce7 to 4d0a88b Compare December 13, 2018 11:38
@hedning hedning merged commit 2727774 into NixOS:master Dec 13, 2018
@hedning hedning deleted the fix-nautilus-thumbnails branch October 15, 2019 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hedning @jtojnar @GrahamcOfBorg