-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lz4: Fix pkgsStatic build #51965
lz4: Fix pkgsStatic build #51965
Conversation
Marked as WIP because of the todos. |
@Mic92 the TODOs are to prevent a mass rebuild, this is good to go as is. |
makeFlags = [ "PREFIX=$(out)" "INCLUDEDIR=$(dev)/include" ] | ||
# TODO always define both | ||
++ stdenv.lib.optional (!enableStatic) "BUILD_STATIC=no" | ||
++ stdenv.lib.optional (!enableShared) "BUILD_SHARED=no" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makeFlags = [
"PREFIX=$(out)"
"INCLUDEDIR=$(dev)/include"
"BUILD_STATIC=${if enableStatic then "yes" else "now"}"
"BUILD_SHARED=${if enableShared then "yes" else "now"}"
]
However it does not prevent a rebuild because |
Advised to mark this WIP by @Ericson2314, changing back. |
4486149
to
7f57dfa
Compare
@Mic92 better now? |
It is still a mass-rebuild because |
7f57dfa
to
e8a7472
Compare
e8a7472
to
cb5a7bd
Compare
Thanks! |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)