Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modemmanager: 1.7.990 -> 1.10.0 #57689

Merged
merged 3 commits into from
Mar 18, 2019
Merged

modemmanager: 1.7.990 -> 1.10.0 #57689

merged 3 commits into from
Mar 18, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Fix #57615

I still need to give the News items a better look.

Probably should add multiple outputs for modemmanager?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS (master)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace requested a review from jtojnar March 15, 2019 12:08
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 501+ 10.rebuild-linux: 501-1000 labels Mar 15, 2019
@jtojnar
Copy link
Member

jtojnar commented Mar 15, 2019

The rest looks fine after consulting the news:

@worldofpeace
Copy link
Contributor Author

Think I did all the things, just need to verify that we actually fixed #41055 by linking the service relatively.

@worldofpeace
Copy link
Contributor Author

Still see the issue described at #41055 (comment) so I'm not going to link it relatively.

@worldofpeace
libmbim: 1.16.2 -> 1.18.0
005c3cf
@worldofpeace
libqmi: 1.20.2 -> 1.22.2
fd5c74c 
Drop --enable-mbim-qmux because we have libmbim >= 1.14.0 [0]

[0]: https://gitlab.freedesktop.org/mobile-broadband/libqmi/blob/1.16.0/NEWS#L5
@worldofpeace
modemmanager: 1.7.990 -> 1.10.0
cb962e8 
* Add flags for systemd [0]

* Enable tests
  Though I actually didn't look to see how they're
  performed, only effort done was to get a success-
  ful build.

* Enable vala bindings

[0]: https://gitlab.freedesktop.org/mobile-broadband/ModemManager/blob/1.8.0/NEWS#L21
@worldofpeace worldofpeace requested a review from jtojnar March 18, 2019 00:38
jtojnar
jtojnar approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for taking care of this.

@worldofpeace
Copy link
Contributor Author

Thanks. Feel free to open more issues for things you'd like taken care of.

@worldofpeace worldofpeace merged commit d22aeb0 into NixOS:staging Mar 18, 2019
@worldofpeace worldofpeace deleted the ModemManager/bump branch March 18, 2019 00:46
@worldofpeace worldofpeace mentioned this pull request Mar 19, 2019
Merged
10 tasks
@flokli flokli mentioned this pull request Mar 20, 2019
Closed
@flokli
Copy link
Contributor

flokli commented Mar 20, 2019

@jtojnar should/can this be backported to 19.03 as well?

@jtojnar
Copy link
Member

jtojnar commented Mar 20, 2019

Probably should.

@flokli
Copy link
Contributor

flokli commented Mar 26, 2019

Backported to 19.03 in 2b1ee54, 4cec8a5 and 65028ce.

@Schweber
Copy link
Contributor

I'm sorry, what is the solution now? How do i disable modem manager?

@jtojnar
Copy link
Member

jtojnar commented Feb 14, 2023

@Schweber you are probably looking for #214086

@Schweber
Copy link
Contributor

@jtojnar I'm looking for a way to uninstall modemmanager if possible. Is there an option for configuration.nix (i didn't find one)?

@jtojnar
Copy link
Member

jtojnar commented Feb 14, 2023

@Schweber lot of software depends on it so there is no easy way. And for questions, it is better to open a thread on Discourse rather than bumping a four year old unrelated pull request.

@NixOS NixOS locked and limited conversation to collaborators Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@worldofpeace @jtojnar @flokli @Schweber @GrahamcOfBorg