Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libsoup: 2.66.1 -> 2.66.2 #61577

Merged
merged 1 commit into from
May 19, 2019
Merged

libsoup: 2.66.1 -> 2.66.2 #61577

merged 1 commit into from
May 19, 2019

Conversation

worldofpeace
Copy link
Contributor

https://gitlab.gnome.org/GNOME/libsoup/blob/2.66.2/NEWS

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS (on master)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from lovek323 and 7c6f434c May 16, 2019 02:26
@worldofpeace
Copy link
Contributor Author

worldofpeace commented May 16, 2019 •
edited
Loading

Looks like glib fails to install on staging, see #61317 (comment). Will push a fix shortly.

@worldofpeace worldofpeace merged commit 3922989 into NixOS:staging May 19, 2019
@worldofpeace worldofpeace deleted the libsoup/2.66.2 branch May 19, 2019 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c approved these changes

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@worldofpeace @7c6f434c