Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helmfile: 0.64.1 -> 0.73.0 #62786

Merged
merged 1 commit into from
Jun 7, 2019
Merged

helmfile: 0.64.1 -> 0.73.0 #62786

merged 1 commit into from
Jun 7, 2019

Conversation

yurrriq
Copy link
Member

@yurrriq yurrriq commented Jun 6, 2019 •
edited
Loading

Motivation for this change

Update to newer version, notably for roboll/helmfile#648.
Also, ditch vgo2nix in favor of buildGoModule, which works better for me anyway.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@yurrriq
Copy link
Member Author

yurrriq commented Jun 6, 2019

@GrahamcOfBorg build helmfile

@ofborg ofborg bot requested a review from kalbasit June 6, 2019 22:27
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jun 6, 2019
@yurrriq
helmfile: 0.64.1 -> 0.73.0
6fed865 
Also, ditch vgo2nix in favor of buildGoModule.
@yurrriq yurrriq force-pushed the update/helmfile branch from 429c698 to 6fed865 Compare June 6, 2019 22:53
@yurrriq
Copy link
Member Author

yurrriq commented Jun 6, 2019

@GrahamcOfBorg build helmfile

@nlewo nlewo merged commit d22cbb4 into NixOS:master Jun 7, 2019
@yurrriq yurrriq mentioned this pull request Jun 7, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yurrriq @nlewo