Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome-hexgl: init at unstable-2019-08-21 #67222

Merged
merged 4 commits into from
Aug 22, 2019
Merged

gnome-hexgl: init at unstable-2019-08-21 #67222

merged 4 commits into from
Aug 22, 2019

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Aug 21, 2019

No description provided.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Aug 21, 2019
@ofborg ofborg bot requested a review from worldofpeace August 21, 2019 22:56
worldofpeace
worldofpeace suggested changes Aug 22, 2019
View reviewed changes
pkgs/development/libraries/mutest/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/mutest/default.nix Show resolved Hide resolved
pkgs/development/libraries/mutest/default.nix Outdated Show resolved Hide resolved
pkgs/games/gnome-hexgl/default.nix Show resolved Hide resolved
pkgs/development/libraries/gthree/default.nix Show resolved Hide resolved
pkgs/development/libraries/gthree/default.nix Show resolved Hide resolved
pkgs/development/libraries/gthree/default.nix Outdated Show resolved Hide resolved
@worldofpeace
Copy link
Contributor

worldofpeace commented Aug 22, 2019 •
edited
Loading

@GrahamcOfBorg test graphene

@ofborg ofborg bot requested a review from worldofpeace August 22, 2019 00:40
@worldofpeace
Copy link
Contributor

@jtojnar It looks like the graphene nixos test fails now.

@jtojnar
Copy link
Member Author

jtojnar commented Aug 22, 2019

The NixOS tests are annoying like that, I need to redirect stderr to stdout like gnome-desktop-testing-runner -d '${pkgs.graphene.installedTests}/share' graphene-1.0/quad.test 2>&1 to be able to see everything in context:

Running test: graphene-1.0/quad.test

  graphene_quad_t
    has bounds
      ✓ converting rect corners into a quad yields the same bounds
      ✓ converting a rect into a quad yields the same bounds
      ✓ point[0] to be top left
free(): invalid pointer
FAIL: graphene-1.0/quad.test (Child process killed by signal 6)

Opened an issue: ebassi/graphene#168

@worldofpeace
Copy link
Contributor

Yeah that test passes in my user environment as well.

worldofpeace
worldofpeace approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jtojnar
Copy link
Member Author

jtojnar commented Aug 22, 2019

Maybe some QEMU SIMD interaction?

@jtojnar jtojnar merged commit b992565 into NixOS:master Aug 22, 2019
@jtojnar jtojnar deleted the glthree branch August 22, 2019 01:18
@worldofpeace
Copy link
Contributor

Maybe some QEMU SIMD interaction?

Possibly, though my knowledge in that area is limited.

The only change that happened to the test between the releases was

@jtojnar jtojnar mentioned this pull request Aug 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtojnar @worldofpeace