Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

whipper: 0.9.0 -> 0.9.1.dev7+g9e95f06 #75765

Merged
merged 1 commit into from
Dec 16, 2019
Merged

whipper: 0.9.0 -> 0.9.1.dev7+g9e95f06 #75765

merged 1 commit into from
Dec 16, 2019

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Dec 16, 2019

Motivation for this change

I jumped the gun a little on #75635; missing dependencies and an upstream issue (whipper-team/whipper#431) meant that the whipper package was currently broken. This bumps it to a git revision with the issue fixed, and as a result I have successfully ripped several CDs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Ma27, if you don't mind merging this one :)

@ofborg ofborg bot requested a review from rycee December 16, 2019 16:08
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 16, 2019
@rycee
Copy link
Member

rycee commented Dec 16, 2019

@GrahamcOfBorg build whipper

@rycee rycee merged commit ea0b237 into NixOS:master Dec 16, 2019
@emilazy emilazy deleted the fix-whipper branch December 16, 2019 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rycee rycee Awaiting requested review from rycee

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilazy @rycee