Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-update: 1.5.2 -> 2.5.0 #77377

Merged
merged 2 commits into from
Feb 17, 2020
Merged

cargo-update: 1.5.2 -> 2.5.0 #77377

merged 2 commits into from
Feb 17, 2020

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Jan 9, 2020 •
edited
Loading

Motivation for this change

https://github.com/nabijaczleweli/cargo-update/releases/tag/v2.5.0

Things done

Changes in this PR:

  • Switch from carnix to buildRustPackage, adding Cargo.lock via cargoPatches
    Upstream seems to be reluctant adding it to the tree.
  • Add pkg-config to buildInputs (for openssl to be found)
  • Refactor
  • Add myself as a maintainer
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
/nix/store/r93n715hv599zh8gq6plamkh1cik8pbd-cargo-update-2.5.0	  37.0M
Notify maintainers

cc @Gerschtli

This change is Reviewable

@ofborg ofborg bot requested a review from Gerschtli January 9, 2020 14:54
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jan 9, 2020
@Br1ght0ne Br1ght0ne mentioned this pull request Jan 9, 2020
Open
Gerschtli
Gerschtli approved these changes Jan 19, 2020
View reviewed changes
Copy link
Contributor

@Gerschtli Gerschtli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

@Br1ght0ne
Copy link
Member Author

cc @marsam for merging. Thanks!

@marsam marsam merged commit 3285f0f into NixOS:master Feb 17, 2020
@marsam
Copy link
Contributor

marsam commented Feb 17, 2020

Thank you, and sorry for the delay

@Br1ght0ne
Copy link
Member Author

No worries, thank you too! I'll address the gist on the next update.

@Br1ght0ne Br1ght0ne deleted the cargo-update-2.5.0 branch February 17, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam left review comments

@Gerschtli Gerschtli Gerschtli approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Br1ght0ne @marsam @Gerschtli