Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

httplz: 1.8.0 -> 1.9.2 #85988

Merged
merged 1 commit into from
Apr 25, 2020
Merged

httplz: 1.8.0 -> 1.9.2 #85988

merged 1 commit into from
Apr 25, 2020

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Apr 25, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/nix/store/spb8i4r5cms0hs87pz0mwvhj2p97z762-httplz-1.8.0 42.8M
/nix/store/7474b16c3cr0gcwszs4wd2qh4bca8hy6-httplz-1.9.2 42.9M

bhipple
bhipple reviewed Apr 25, 2020
View reviewed changes
pkgs/tools/networking/httplz/default.nix
@@ -19,7 +19,7 @@ rustPlatform.buildRustPackage rec {

cargoBuildFlags = [ "--bin httplz" ];
cargoPatches = [ ./cargo-lock.patch ];
Copy link
Contributor

@bhipple bhipple Apr 25, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can, it'd be nice to ask upstream to start checking in the cargo.lock with their releases (or send them a pull request that does this), as this is recommended best practice from the Cargo Book:
https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/rust.section.md#compiling-rust-applications-with-cargo

Then we could drop this ugly patch entirely.

Moreover, it'd let the nixpkgs-update bot generate and send PRs to do this automatically.

Copy link
Contributor Author

@bbigras bbigras Apr 25, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know but at least one of the devs is a heretic. 😞 thecoshman/http#84

Moreover, it'd let the nixpkgs-update bot generate and send PRs to do this automatically.

I know 😢

I'm sure there's a lot of other nice packages with the same features. Maybe we should just drop this package and move on.

@bhipple
Copy link
Contributor

bhipple commented Apr 25, 2020

Result of nixpkgs-review pr 85988 1

1 package built:
- httplz

@bhipple bhipple merged commit d761d9c into NixOS:master Apr 25, 2020
@bbigras bbigras deleted the httplz branch April 25, 2020 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bbigras @bhipple