Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: jdk: make it point to latest version #88714

Closed
wants to merge 1 commit into from

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented May 23, 2020

Motivation for this change

I want to encourage contributors to use (or at least try to use) the latest openjdk when they add new derivations that need Java. This change strives to make jdk point to the latest jdk, while every other derivation that uses jdk without an explicit version suffix, now uses jdk8 explicitly.

I'm still waiting for ofborg to tag this PR as "10.rebuild-linux: 0", that's why it's a draft.

See also https://discourse.nixos.org/t/nixpkgs-policy-regarding-libraries-available-in-multiple-versions/7026 .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels May 23, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nixpkgs-policy-regarding-libraries-available-in-multiple-versions/7026/4

@doronbehar
Copy link
Contributor Author

I'm thinking that perhaps, it'll be better to make jdk point to the latest openjdk, but write a script that will make every derivation that has jdk in it's arguments, use jdk8 explicitly. This way, the PR will be tagged as 0: rebuild-linux and so it'll be still easy enough to merge this.

Make every other derivation, use jdk8 explicitly, so attributes won't
appear as changed by ofborg.
@doronbehar doronbehar changed the title jdk_latest: init at 14 treewide: jdk: make it point to latest version Jun 1, 2020
@doronbehar doronbehar marked this pull request as draft June 1, 2020 10:32
@ofborg ofborg bot added 6.topic: haskell 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 6.topic: steam Steam game store/launcher (store.steampowered.com) 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: clean-up 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jun 1, 2020
@doronbehar
Copy link
Contributor Author

Closed in favor of #89731 .

@doronbehar doronbehar closed this Jun 7, 2020
@doronbehar doronbehar deleted the jdk_latest branch March 2, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: haskell 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 6.topic: steam Steam game store/launcher (store.steampowered.com) 8.has: clean-up 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants