Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keystore-explorer: init at 5.4.4 #96046

Merged
merged 1 commit into from
Dec 21, 2020
Merged

keystore-explorer: init at 5.4.4 #96046

merged 1 commit into from
Dec 21, 2020

Conversation

numinit
Copy link
Contributor

@numinit numinit commented Aug 23, 2020 •
edited
Loading

Motivation for this change

Adding piece of fairly widely used software.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@numinit numinit added the 8.has: package (new) This PR adds a new package label Aug 23, 2020
@numinit numinit requested a review from offlinehacker August 23, 2020 01:35
@numinit
Copy link
Contributor Author

numinit commented Aug 23, 2020

Somewhat related software to easyrsa.

@numinit numinit requested a review from risicle September 2, 2020 01:41
@numinit numinit changed the title keystore-explorer: init at 5.4.3 keystore-explorer: init at 5.4.4 Dec 5, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/395

doronbehar
doronbehar requested changes Dec 18, 2020
View reviewed changes
pkgs/applications/misc/keystore-explorer/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/keystore-explorer/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/keystore-explorer/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/keystore-explorer/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/keystore-explorer/default.nix Outdated
cp -R ./* $out/
rm $out/kse.exe
mv $out/kse.sh $out/keystore-explorer.sh
ln -s $out/keystore-explorer.sh $out/bin/keystore-explorer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just put 1 install -D kse.sh $out/bin/keystore-explorer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ended up having to directly write the script similarly to jd-gui: https://github.com/NixOS/nixpkgs/blob/master/pkgs/tools/security/jd-gui/default.nix#L90

pkgs/applications/misc/keystore-explorer/default.nix Outdated

meta = {
description = "Open source GUI replacement for the Java command-line utilities keytool and jarsigner";
license = stdenv.lib.licenses.gpl3;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gpl3 is ambitious. See https://discourse.nixos.org/t/lib-licenses-gpl3-co-are-now-deprecated/8206 .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to gpl3Only since keystore-explorer currently advertises GPL3 on github.

@numinit
Copy link
Contributor Author

numinit commented Dec 19, 2020

Thanks for the comments - this derivation was adapted from someone's previous nixpkgs build of keystore-explorer. I'll give the build another look to clean it up...

@numinit
Copy link
Contributor Author

numinit commented Dec 20, 2020

Alright, that should be a bit better. Also explicitly used jdk8, as more testing revealed crashes with jdk11+.

@numinit numinit force-pushed the keystore-explorer branch 2 times, most recently from c895670 to 326d8a6 Compare December 20, 2020 02:13
@doronbehar
Copy link
Contributor

Result of nixpkgs-review pr 96046 run on x86_64-linux 1

1 package built:
  • keystore-explorer

@doronbehar doronbehar merged commit bcf07ee into NixOS:master Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@risicle risicle Awaiting requested review from risicle

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@numinit @nixos-discourse @doronbehar