-
-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.gssapi: fix tests, 1.6.2 -> 1.6.9 #97873
Conversation
should also remove shouldbe from the dependencies, or else that failure will propagate to gssapi:
|
also related: pythongssapi/python-gssapi#215 |
the failing tests appear to also be causing trouble upstream
059fbef
to
f56a8ba
Compare
Well ok, suppose that just means I've got to disable the tests for python 3.8 then - On that note, it would be pretty useful to be able to introspect into packages to see if they're "disabled", allowing us to switch on that condition rather than replicate the logic of " |
Yea, that seems fine
The problem is that "disabling" a package just correlates to throwing an error. And this is kind of an "exceptional" problem, as most upstreams aren't completely dead. It's unfortunate that upstream invested so much in an upstream library. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Result of nixpkgs-review pr 97873 1
2 packages failed to build:
- python38Packages.asyncssh
- python38Packages.gssapi
2 packages built:
- python37Packages.asyncssh
- python37Packages.gssapi
not sure why report was wrong:
|
Motivation for this change
ZHF: #97479
The failing tests seem to be causing trouble upstream too (pythongssapi/python-gssapi#220), so I skipped them (which itself wasn't particularly simple thanks to
nosetests
).Also bumped to latest version, mostly to get python 3.8 working. Though this does have the effect of dropping python 2.7 support 🤷
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)