-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apache-kafka: Fix, update and adjust JRE/JVM #98446
Conversation
Force pushed to use the headless variants, the default ones pull in a ton of X deps. |
@srhb, please resolve the conflict. furthermore, about the JVM option. #100115 thanks @NeQuissimus are you maintainter here? |
717bc06
to
4af0b62
Compare
Conflicts resolved. 🙂 |
@srhb LGTM but can you add 2.6 to the test suite, please? :) |
Thought I did already in a912e93276835b377dd0ad02fcfebf9e5e5f8cfe - did I miss another place? |
Oh wow, I must be blind :D |
Any progress on this? |
This should be good to go after a rebase |
I'm sorry, I forgot all about this. I'll fix it up now. |
Hey no worries :) Thank you very much for the PR and the quick rebase. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Only 2.6.X recommends Scala 2.13, so use 2.12
I'm going to go ahead and merge once ofborg passes since there's some approval at least, and I don't want to play whack-a-mole with the release note merge conflicts. :-) |
Most Kafka versions were broken by the recent jdk/jre changes in #89731 but it needed some cleanup work anyway. 😄
I've enriched the package versions with relevant JRE compatibility, and passed it through so that the module can take advantage of it to set a jre by default (new option) that corresponds in the service.
Also remove the default
jvmOptions
to avoid having to pass these through in version-compatible permutations. Users should adjust them according to the version they use, so add a release note that warns about this.Also adds the latest kafka 2.6, sets it to the default
apacheKafka
and adjust the Scala version used for2.5.X
according to upstream recommendations.Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)