Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cope with maintainer entries using a non-github contact #665

Open
wants to merge 1 commit into
base: released
Choose a base branch
from

Conversation

zeuner
Copy link

@zeuner zeuner commented Dec 11, 2023

There has been discussion (NixOS/nixpkgs#273146 (comment)) implying that the current ofborg implementation may have issues coping with our year-long proven maintainer list data model, but I could not find a corresponding issue report. Therefore, I tried to come up with a fix that should help against the listToPing function failing.

If there are more details about the issues faced, sharing them would be shared. This might allow me to improve this PR.

Of course this does not replace the need to provide ping handlers for the other contact entry variants, which will be processed in separate PRs.

@zeuner zeuner marked this pull request as draft December 11, 2023 11:34
pkg.maintainers
(builtins.filter
(maintainer:
pkgs.lib.hasAttrByPath ["github"] maintainer)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pkgs.lib.hasAttrByPath ["github"] maintainer)
pkgs.lib.hasAttrByPath [ "github" ] maintainer)

Apparently people like these spaces. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants