-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC 0127] Nixpkgs "problem" infrastructure #127
Conversation
This RFC is now open for shepherd nominations! |
I nominate myself as a shepherd for this RFC. |
I will also nominate myself as shepherd. |
Definitely. We should just be careful to keep that path open in the RFC. |
Linking to NVD is not the best URL I could imagine. When it comes to security issues, advisories are often a far better understandable resource, than a central database that advertises CVSS scores, which are often so-so. Hence, I don't think auto-referencing NVD is really important here. |
As NVD usually has more or less reasonable summary and links to better write-ups, I think auto-linking NVD when there is no better link provided is useful (and fetching their links is impure so can't be done within Nix). |
I feel like this is security team's call to decide what to do on this and is tangent to this RFC though. |
The About generating those automatically, I don't know. I'm not a fan of doing some fuzzy matching on inputs in general, and also is pasting in a link every blue moon really so much effort that it is worth automating away? (https://xkcd.com/1205/ says no) |
I agree with you on the quality statement. :) |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-50/29793/1 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-51/30870/1 |
* [RFC 0127] Nixpkgs issues and warnings (NixOS#127) * Add URLs as structured information * Update rfcs/0127-issues-warnings.md Co-authored-by: Linus Heckemann <git@sphalerite.org> * Update rfcs/0127-issues-warnings.md Co-authored-by: Linus Heckemann <git@sphalerite.org> * Update rfcs/0127-issues-warnings.md Co-authored-by: Linus Heckemann <git@sphalerite.org> * Update rfcs/0127-issues-warnings.md Co-authored-by: Linus Heckemann <git@sphalerite.org> * Update rfcs/0127-issues-warnings.md Co-authored-by: Linus Heckemann <git@sphalerite.org> * Update rfcs/0127-issues-warnings.md * RFC 127 update shepherds * RFC 127 rework * Point out that the previous warnings system was not documented * Rework ignore mechanism * Update rfcs/0127-issues-warnings.md Co-authored-by: Silvan Mosberger <github@infinisil.com> * Update rfcs/0127-issues-warnings.md Co-authored-by: Silvan Mosberger <github@infinisil.com> * Remove "resolved" attribute again * Incorporate review feedback * Rewrite (again) * Rename throw->error, trace->warn * Make meta.problems an attrset * Rewrite *again*, most change is in the configuration options * Review update (WIP) * Review update * Update shepherds list * Meeting update * Typos --------- Co-authored-by: Linus Heckemann <git@sphalerite.org> Co-authored-by: Silvan Mosberger <github@infinisil.com>
Rendered
Implementation PR
Matrix discussion room:
#nixos-rfc-127:lossy.network
Pre-RFC discussion
Discussion notice: please try to attach all discussions to a thread by using the code review feature. If your comment doesn't refer a specific line to attach to, use the header line instead.