-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC 0146] Meta.Categories, not Filesystem Directory Trees #146
Changes from 10 commits
610c110
415c97a
a908922
f2eac8d
5444d90
93ef176
2bf1c25
e29a413
79b92e9
004fc01
6289abe
602e521
fd1d6af
c30ff6c
907d510
4d02382
0a868c6
e258926
98a8348
cc8caa3
618dc67
abbf7fd
0e21673
21ec340
a18c24a
f771094
eb079f6
0ad89e7
fa75eec
ee8633c
2dcb0ed
e0ee96f
a029a22
172cc8e
fdc2424
11a7757
bcc2444
9979bef
f643103
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,263 @@ | ||
--- | ||
feature: Decouple filesystem from categorization | ||
start-date: 2023-04-23 | ||
author: Anderson Torres | ||
co-authors: (find a buddy later to help out with the RFC) | ||
shepherd-team: (names, to be nominated and accepted by RFC steering committee) | ||
shepherd-leader: (name to be appointed by RFC steering committee) | ||
related-issues: (will contain links to implementation PRs) | ||
--- | ||
|
||
# Summary | ||
[summary]: #summary | ||
|
||
Deploy a new method of categorization for the packages maintained by Nixpkgs, | ||
not relying on filesystem idiosyncrasies. | ||
|
||
# Motivation | ||
[motivation]: #motivation | ||
|
||
Currently, Nixpkgs uses the filesystem, or more accurately, the directory tree | ||
layout in order to informally categorize the softwares it packages, as described | ||
in the [Hierarchy](https://nixos.org/manual/nixpkgs/stable/#sec-hierarchy) | ||
section of Nixpkgs manual. | ||
|
||
This is a simple, easy to understand and consecrated-by-use method of | ||
categorization, partially employed by many other package managers like GNU Guix | ||
and NetBSD pkgsrc. | ||
|
||
However this system of categorization has serious problems: | ||
|
||
1. It is bounded by the constraints imposed by the filesystem. | ||
|
||
- Restrictions on filenames, subdirectory tree depth, permissions, inodes, | ||
quotas, and many other things. | ||
- Some of these restrictions are not well documented and are found simply | ||
by "bumping" on them. | ||
- The restrictions can vary on an implementation basis. | ||
- Some filesystems have more restrictions or less features than others, | ||
forcing an uncomfortable lowest common denominator. | ||
- Some operating systems can impose additional constraints over otherwise | ||
full-featured filesystems because of backwards compatibility (8 dot | ||
3,anyone?). | ||
|
||
2. It requires a local checkout of the tree. | ||
|
||
Certainly this checkout can be "cached" using some form of `find . > | ||
/tmp/pkgs-listing.txt`, or more sophisticated solutions like `locate + | ||
updatedb`. Nonetheless such solutions still require access to a fresh, | ||
updated copy of the Nixpkgs tree. | ||
|
||
3. The creation of a new category - and more generally the manipulation of | ||
categories - requires an unpleaseant task of renaming and eventually patching | ||
many seemingly unrelated files. | ||
|
||
- Moving files around Nixpkgs codebase requires updating their forward and | ||
backward references. | ||
- Especially in some auxiliary tools like editor plugins, testing suites, | ||
autoupdate scripts and so on. | ||
- Rewriting `all-packages.nix` can be error-prone (even using Metapad) and it | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also, |
||
can generate huge, noisy patches. | ||
|
||
4. There is no convenient way to use multivalued categorization. | ||
|
||
A piece of software can fulfill many categories; e.g. | ||
- an educational game | ||
- a console emulator (vs. a PC emulator) | ||
- and a special-purpose programming language (say, a smart-contracts one). | ||
|
||
The current one-size-fits-all restriction is artificial, imposes unreasonable | ||
limitations and results in incomplete and confusing information. | ||
|
||
- No, symlinks or hardlinks are not convenient for this purpose; not all | ||
environments support them (falling on the "less features than others" | ||
problem expressed before) and they convey nothing besides confusion - just | ||
think about writing the corresponding entry in `all-packages.nix`. | ||
|
||
5. It puts over the (possibly human) package writer the mental load of where to | ||
put the files on the filesystem hierarchy, deviating them from the job of | ||
really writing them. | ||
|
||
- Or just taking the shortest path and throw it on a folder under `misc`. | ||
|
||
6. It "locks" the filesystem, preventing its usage for other, more sensible | ||
purposes. | ||
|
||
7. The most important: the categorization is not discoverable via Nix language | ||
infrastructure. | ||
|
||
Indeed there is no higher level way to query about such categories besides | ||
the one described in the bullet 2 above. | ||
Comment on lines
+86
to
+90
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Idk, this might be a bit off topic, but one use case this RFC would enable is to have something like There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am not sure how to word such a use case carefully, given that many packages contain multiple GUI applications that can be launched without arguments, and then some more programs where command-line arguments are expected. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To me it looks like an extra application that uses the Nixpkgs metadata as a filter. Something like |
||
|
||
In light of such a bunch of problems, this RFC proposes a novel alternative to | ||
the above mess: new `meta` attributes. | ||
|
||
AndersonTorres marked this conversation as resolved.
Show resolved
Hide resolved
|
||
# Detailed design | ||
[design]: #detailed-design | ||
|
||
A new attribute, `meta.categories`, will be included for every Nix expression | ||
AndersonTorres marked this conversation as resolved.
Show resolved
Hide resolved
|
||
living inside Nixpkgs. | ||
|
||
This attribute will be a list, whose elements are one of the possible elements | ||
of the `lib.categories` set. | ||
|
||
A typical snippet of `lib.categories` will be similar to: | ||
|
||
```nix | ||
{ | ||
assembler = { | ||
name = "Assembler"; | ||
description = '' | ||
A program that converts text written in assembly language to binary code. | ||
''; | ||
}; | ||
|
||
compiler = { | ||
name = "Compiler"; | ||
description = '' | ||
A program that converts a source from a language to another, usually from | ||
a higher, human-readable level to a lower, machine level. | ||
''; | ||
}; | ||
|
||
font = { | ||
name = "Font"; | ||
description = '' | ||
A set of files that defines a set of graphically-related glyphs. | ||
''; | ||
}; | ||
|
||
game = { | ||
name = "Game"; | ||
description = '' | ||
A program developed with entertainment in mind. | ||
''; | ||
}; | ||
|
||
interpreter = { | ||
name = "Interpreter"; | ||
description = '' | ||
A program that directly executes instructions written in a programming | ||
language, without requiring compilation into the native machine language. | ||
''; | ||
}; | ||
|
||
``` | ||
|
||
# Examples and Interactions | ||
[examples-and-interactions]: #examples-and-interactions | ||
|
||
In file bochs/default.nix: | ||
|
||
```nix | ||
stdenv.mkDerivation { | ||
|
||
. . . | ||
|
||
meta = { | ||
. . . | ||
categories = with lib.categories; [ emulator debugger ]; | ||
. . . | ||
}; | ||
}; | ||
} | ||
|
||
``` | ||
|
||
In a `nix repl`: | ||
|
||
``` | ||
nix-repl> :l <nixpkgs> | ||
Added XXXXXX variables. | ||
|
||
nix-repl> pkgs.bochs.meta.categories | ||
[ { ... } ] | ||
|
||
nix-repl> map (z: z.name) pkgs.bochs.meta.categories | ||
[ "debugger" "emulator" ] | ||
``` | ||
|
||
# Drawbacks | ||
[drawbacks]: #drawbacks | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What about ease/speed of finding all packages of a specific category or a set of categories ? I mean: by using a list of categories it means that to find all (not 100% sure about it) One way to make single category lookup fast could be to generate a lookup attrset like: {
meta.categories_lookup = { compiler = lib.categories.compiler; . . . };
} Another way could be to NOT use a list of categories in the first place and directly use an attrset like that one above. And get the added benerit of inherit to easily write it (avoiding one more usage of {
meta.categories = { inherit (lib.categories) compiler; . . . };
} The only downside I see is that we loose the ordering of categories (not mentioned yet, but the first one could mark the pkg's primary category) on the other hand it removes a bikeshed waiting to happen (how to order categories). To check if a package has a set of categories I don't think there's a better way than to check if the pkg is in the first category, then the second, etc.. What do you think? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hum, the problem I can see is that it would be not orthogonal. Look: {
. . .
meta = {
maintainers = [ maintainers.MeMyselfAndI ];
categories = { inherit (lib.categories) compiler; }
};
. . .
} Why maintainers is a list while categories is a strange dictionary? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
That can be solved by migrating maintainers list to a dictionary. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. One could switch meta to attrubute sets, but currently it's all lists, yeah, so makes sense to follow this tradition |
||
|
||
The most immediate drawbacks are: | ||
|
||
1. A huge treewide edit of Nixpkgs | ||
|
||
On the other hand, this is easily sprintable and amenable to automation. | ||
|
||
2. Bikeshedding | ||
|
||
How many and which categories we should create? Can we expand them later? | ||
Comment on lines
+209
to
+211
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Allowing to add, remove, or split categories would mean that any bikeshedding wouldn't block other processes, which is a good thing. |
||
|
||
For start, we can follow/take inspiration from many of the already existing | ||
categories sets and add extra ones when the needs arise. Indeed, it is way | ||
easier to create such categories using Nix language when compared to other | ||
software collections. | ||
|
||
# Alternatives | ||
[alternatives]: #alternatives | ||
|
||
1. Do nothing | ||
|
||
This will exacerbate the problems already listed. | ||
|
||
2. Ignore/nuke the categorization completely | ||
|
||
This is not an idea as bad as it appear. After all, categorization has a | ||
non-negligible propensity to bikeshedding. Removing it removes all problems. | ||
|
||
However, there are good reasons to keep the categorization: | ||
|
||
- The categorization is already present; this RFC proposes to expose it to a | ||
higher level, in a more discoverable, structured format. | ||
|
||
- Categorization is very traditional among software collections. Many of them | ||
are doing this just fine for years on end, and we can easily imitate them - | ||
and even better, given we have Nix language machinery available. | ||
|
||
- A well-made categorization is useful for specialized search engines, | ||
adding a new field for narrowing searches. | ||
|
||
- The complete removal of categorization is too harsh. A solution that keeps | ||
and enhances the categorization is way more preferrable than one that nukes | ||
it completely. | ||
|
||
AndersonTorres marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Another alternative might be an open taxonomy. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. +1. It would allow us to import the existing categories as they are, and thanks to nix we can map them to freedesktop categories in the category definition, like the current license-spdx mapping There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well, I believe I can produce some preliminar code on this regard. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here's a largely uncontrolled categorization, although skewed by a built in scaffolding tool that only suggests some 20 categories: Haskell packages by category My takeaways:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have proposed something like "related categories" on the preliminary code: |
||
# Unresolved questions | ||
[unresolved]: #unresolved-questions | ||
|
||
Still unsolved is what data structure is better suited to represent a category. | ||
|
||
- For now we stick to a set `{ name, description }`. | ||
- Given the redundancy of the option above, another possibility is something | ||
like `nameOfCategory = { description = ""; . . . }` | ||
|
||
# Future work | ||
[future]: #future-work | ||
|
||
- Curate the categories. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is imo the most important thing, a categorization is useless if it isn't curated. Unfortunately this is really not trivial, because both the set of packages and categories are really large, any package could be in any category, and both of them change over time. So I would like to see some automated process for this, here's an idea for a very fancy one:
I have a feeling that a Nixpkgs-specific website would be great to integrate this all together, along with E-Mails for notifications. Maybe this could be combined into e.g. a maximum once-per-week E-Mail, asking package maintainers to perform necessary actions to maintain their packages, which could also include things like reviewing relevant PR's or issues, tending to Hydra build failures, etc. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we shouldn't reinvent the wheel and work as much as possible with existing categorization data. For example, many applications have desktop files whose categories (and tags) one could use. And maybe repology has something useful too There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should not be too hard. The not-so-good parts are to convert from filesystem classification
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess that is a benefit of having to decide on exactly one category for a package: Either you'll find the most accurate category, or none of them apply which justifies creating a new one. Therefore there is no general category maintenance required, it happens naturally as packages get added. We should consider this as an alternative, something like meta = {
category = lib.categories.compiler;
} And if we want to be more specific we could have category and subcategory, or something like that There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I feel this is not good, because it would defeat the cases of multi-valued categorization. What about mail server, game server, file server...? One category for each looks too much. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah I agree it's not perfect, but if I had to choose between a curated single-valued categorization and an uncurated multi-valued one, I think I'd pick the former. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. At least the multi-valued version can include all that others (including upstreams, if they provide some of the many categorisation labels) think too. Agreeing on the layout of anything single-valued will go as well as any attempt to globally agree on anything in Nixpkgs, it will be a weird and inconvenient to all (but in different ways, of course) compromise. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
An uncurated multi-valued can possibly be curated in a mostly independent fashion - curating does not block a package's inclusion. On the other hand, seeking the most fitting one-valued category puts a non-negligible mental load for each single package. I aggree it is better the curation than the non-curation, but we have the option of a multi-valued curation. |
||
- Update documentation. | ||
- Update Continuous Integration. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It would be nice if categories could be discovered and filtered for PR review using github tags. This would be useful for quickly merging trivial packages like games. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Agree that it would be nice, unsure if it needs spelling out explicitly as a part of «Update CI». Or maybe some version of this could go into motivation? |
||
|
||
# References | ||
[references]: #references | ||
|
||
- [Desktop Menu | ||
Specification](https://specifications.freedesktop.org/menu-spec/latest/); | ||
specifically, | ||
- [Main | ||
categories](https://specifications.freedesktop.org/menu-spec/latest/apa.html) | ||
- [Additional | ||
categories](https://specifications.freedesktop.org/menu-spec/latest/apas02.html) | ||
- [Reserved | ||
categories](https://specifications.freedesktop.org/menu-spec/latest/apas03.html) | ||
|
||
- [NetBSD pkgsrc guide](https://www.netbsd.org/docs/pkgsrc/) | ||
- Especially, [Chapter 12, Section | ||
1](https://www.netbsd.org/docs/pkgsrc/components.html#components.Makefile) | ||
contains a short list of CATEGORIES. | ||
|
||
- [FreeBSD Porters | ||
Handbook](https://docs.freebsd.org/en/books/porters-handbook/makefiles/#porting-categories) | ||
- Especially | ||
[Categories](https://docs.freebsd.org/en/books/porters-handbook/makefiles/#porting-categories) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would anyone like to be the leader?