Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC 0167] nixpkgs maintainer requirements #167

Closed
wants to merge 3 commits into from

Conversation

adamcstephens
Copy link

@adamcstephens adamcstephens commented Dec 19, 2023

This PR adds an expectation and requirement for nixpkgs maintainers to include two forms of contact information. The first is an account on the nixpkgs hosting platform (GitHub) and the second is an alternative form such as email, matrix and adds discourse.

Rendered
final maintainer-list.nix

@infinisil infinisil added the status: open for nominations Open for shepherding team nominations label Jan 10, 2024
@infinisil
Copy link
Member

This RFC has not acquired enough shepherds. This typically shows lack of interest from the community. In order to progress a full shepherd team is required. Consider trying to raise interest by posting in Discourse, talking in Matrix or reaching out to people that you know.

If not enough shepherds can be found in the next month we will close this RFC until we can find enough interested participants. The PR can be reopened at any time if more shepherd nominations are made.

See more info on the Nix RFC process here

@Janik-Haag
Copy link
Member

I would like to nominate myself as shepherd. I don't have prior experience shepherding a RFC, but I do know how to engage with the community and get things moving.

@piegamesde
Copy link
Member

I nominate @RaitoBezarius, which I know has already spent a lot of time thinking about this topic

@RaitoBezarius
Copy link
Member

I nominate @RaitoBezarius, which I know has already spent a lot of time thinking about this topic

I humbly accept.

@kevincox
Copy link
Contributor

I see two shepherds.

Looking for 1 more.

@JulienMalka
Copy link
Member

I see two shepherds.

Looking for 1 more.

I am willing to be a shepherd

Comment on lines +6 to +7
shepherd-team: (names, to be nominated and accepted by RFC steering committee)
shepherd-leader: (name to be appointed by RFC steering committee)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
shepherd-team: (names, to be nominated and accepted by RFC steering committee)
shepherd-leader: (name to be appointed by RFC steering committee)
shepherd-team: @Janik-Haag, @RaitoBezarius, @JulienMalka
shepherd-leader: @Janik-Haag

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamcstephens Can you please merge this change?

@infinisil infinisil added status: in discussion and removed status: open for nominations Open for shepherding team nominations labels Mar 5, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/rfcsc-meeting-2024-03-05/40851/1

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/rfcsc-meeting-2024-03-19/41829/1

Copy link
Member

@sternenseemann sternenseemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to introduce a lot of unnecessary bureaucracy with no real upside because it doesn't change what maintainers' responsibilities, despite being reachable which is in and of itself not very valuable.

I also doubt that this is really required since it is perfectly possible to remove maintainers from the list at the moment if it bothers anyone. Removing maintainers that have been inactive for a while if it is okay with the other maintainers is not a problem at all — no one is going to oppose that in practice.

Establishing a formal policy may just lead to unnecessary busywork where people start creating mass PRs of maintainer removals that creates a lot of noise for no real benefit.

rfcs/0167-maintainer-account.md Outdated Show resolved Hide resolved
@adamcstephens
Copy link
Author

This seems to introduce a lot of unnecessary bureaucracy with no real upside because it doesn't change what maintainers' responsibilities, despite being reachable which is in and of itself not very valuable.

I'd argue that being reachable is value and should be a minimum requirement of being a maintainer. How will you respond to issues with packages you maintain if you can't be reached?

One of the core tenants of this RFC is to establish a requirement for maintainers to have an account on the nixpkgs hosting platform (aka GitHub). This does have value as spelled out in the RFC.

@sternenseemann
Copy link
Member

One of the core tenants of this RFC is to establish a requirement for maintainers to have an account on the nixpkgs hosting platform (aka GitHub). This does have value as spelled out in the RFC.

Have you tried establishing how many maintainers actually don't have a GitHub account (which isn't the same as how many lib.maintainers entries don't have a github account associated)? I doubt there will be more than a handful since it has been cumbersome and unreliable to contribute to nixpkgs without a GitHub account for a while now. Maintainers without a GitHub account are probably inactive by now anyways, as the discourse patch category is practically unusable and efforts like nixpkgs-dev have stalled.

To me it looks like this is, if anything, a matter of clean up and amending the missing github account names to the maintainer list – both shouldn't require an RFC as well.

@adamcstephens
Copy link
Author

adamcstephens commented Mar 20, 2024

To me it looks like this is, if anything, a matter of clean up and amending the missing github account names to the maintainer list – both shouldn't require an RFC as well.

I would tend to agree, but unfortunately such changes have in the past not been well received and some do consider this a significant enough change to warrant the RFC process. I’m happy to modify the scope of what is currently written here, but unless something has changed some of this cannot be implemented by PR alone.

The requirement for an account may seem logical, but has not been consistently followed. We need to make it official.

Relates to: NixOS/nixpkgs#273220 NixOS/nixpkgs#272199 NixOS/nixpkgs#273146

rfcs/0167-maintainer-account.md Outdated Show resolved Hide resolved
rfcs/0167-maintainer-account.md Outdated Show resolved Hide resolved
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/rfcsc-meeting-2024-04-02/42643/1

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/rfcsc-meeting-2024-04-16/43512/1

@Aleksanaa Aleksanaa mentioned this pull request Apr 18, 2024
13 tasks
@adamcstephens
Copy link
Author

For those following along, the changes in maintainer-list.nix are now presented as a diff. The final rendered version of this file is now linked in the original description and is here https://github.com/adamcstephens/nixpkgs/blob/rfc0167/maintainers/maintainer-list.nix

As working on this, I wondered if maybe we should also move all of this content to the README.md in maintainers/ and put a reference note in the current location. This would allow for proper markdown rendering and niceties. :) Thoughts?

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/rfcsc-meeting-2024-05-14/45414/1

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/rfcsc-meeting-2024-05-28/46113/1

@kevincox
Copy link
Contributor

RFCSC: @Janik-Haag is there anything blocking this PR moving forward? Can you post a status update, indicate the next steps or organize a shepherd meeting that can help move this RFC to completion.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/rfcsc-meeting-2024-06-10/46817/1

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/rfcsc-meeting-2024-06-24/47589/1

@adamcstephens
Copy link
Author

I don't plan to pursue this any further, and the shepherd has left the community. Feel free to adopt as desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.