Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] ReVin Numerical Stability #781

Merged
merged 3 commits into from
Oct 13, 2023
Merged

[FIX] ReVin Numerical Stability #781

merged 3 commits into from
Oct 13, 2023

Conversation

dluuo
Copy link
Contributor

@dluuo dluuo commented Oct 9, 2023

This is a small fix for the ReVin implementation, moving the epsilon outside of ReLU, ensuring that it is nonzero.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CLAassistant
Copy link

CLAassistant commented Oct 9, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@cchallu cchallu self-requested a review October 10, 2023 13:27
@kdgutier kdgutier added the bug label Oct 13, 2023
@cchallu cchallu merged commit b7ab0a6 into Nixtla:main Oct 13, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants