Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Exception: max_epochs is deprecated, use max_steps instead. #835

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

twobitunicorn
Copy link
Contributor

Title says it all. Appreciate all the work!

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CLAassistant
Copy link

CLAassistant commented Dec 4, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Joseph N. Ruskiewicz seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jmoralez
Copy link
Member

jmoralez commented Dec 5, 2023

Thanks for this. Can you please also modify the README?

@twobitunicorn
Copy link
Contributor Author

@jmoralez The README.md seems to have already been updated to reflect the change. I checked both my fork and the main branch. Can you please check that on yours? Thanks.

@jmoralez
Copy link
Member

jmoralez commented Dec 6, 2023

Ah yeah, my bad.

@jmoralez
Copy link
Member

jmoralez commented Dec 6, 2023

Hey @twobitunicorn, can you please sign the CLA?

@twobitunicorn
Copy link
Contributor Author

@jmoralez my bad! all signed.

@jmoralez
Copy link
Member

jmoralez commented Dec 6, 2023

I think each commit has a different email. Can you maybe squash them into a single one with the same user?

@twobitunicorn
Copy link
Contributor Author

That was weird. Sorry about that. Should be fixed.

Copy link
Member

@jmoralez jmoralez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jmoralez jmoralez merged commit 0d37cdc into Nixtla:main Dec 7, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants