Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use future instead of deprecation warnings #849

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Conversation

jmoralez
Copy link
Member

@jmoralez jmoralez commented Jan 2, 2024

The default warning filters ignore deprecation warnings (docs). This changes the category of the issued warnings from DeprecationWarning to FutureWarning in order to provide more visibility of future breaking changes to our users.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jmoralez jmoralez changed the title Use future warnings use future instead of deprecation warnings Jan 2, 2024
@jmoralez jmoralez requested a review from cchallu January 2, 2024 20:38
@jmoralez jmoralez marked this pull request as ready for review January 2, 2024 20:38
Copy link
Contributor

@cchallu cchallu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@jmoralez jmoralez merged commit 6371cce into main Jan 9, 2024
15 checks passed
@jmoralez jmoralez deleted the use-future-warnings branch January 9, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants