Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support different column names for ids, times and targets #718

Merged
merged 4 commits into from
Dec 8, 2023

Conversation

jmoralez
Copy link
Member

@jmoralez jmoralez commented Dec 5, 2023

  • Adds support for providing id_col, time_col and target_col to the methods that take a dataframe so that different column names can be used, i.e. removes the restriction on unique_id, ds, y.
  • Makes the forwarding of the arguments to the distributed backends explicit.
  • Removes the distributed.utils module, which doesn't seem to be used anymore along with the _nbdev.py file (from nbdev1).
  • Fixes some docstrings but I'll make another PR to define them only once and set them in all of the methods to make it easier and ensure they're consistent. Templates the common arguments in the docstrings to ensure consistency and to make it easier to update them.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jmoralez jmoralez marked this pull request as ready for review December 6, 2023 16:40
Copy link
Member

@AzulGarza AzulGarza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jmoralez! This is a great improvement. I just left a comment regarding the documentation of X_df.

statsforecast/_nbdev.py Outdated Show resolved Hide resolved
statsforecast/core.py Outdated Show resolved Hide resolved
statsforecast/core.py Outdated Show resolved Hide resolved
Copy link
Member

@AzulGarza AzulGarza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jmoralez jmoralez merged commit 03673b7 into main Dec 8, 2023
17 checks passed
@jmoralez jmoralez deleted the support-colnames branch December 8, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants