support different column names for ids, times and targets #718
+1,307
−947
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
id_col
,time_col
andtarget_col
to the methods that take a dataframe so that different column names can be used, i.e. removes the restriction on unique_id, ds, y.Fixes some docstrings but I'll make another PR to define them only once and set them in all of the methods to make it easier and ensure they're consistent.Templates the common arguments in the docstrings to ensure consistency and to make it easier to update them.