Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency cmdk to v1 #36

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update dependency cmdk to v1 #36

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 13, 2024 •
edited
Loading

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
cmdk (source) ^0.2.0 -> ^1.0.0 age adoption passing confidence

Release Notes

pacocoursey/cmdk (cmdk)

v1.0.4

Compare Source

What's Changed

New Contributors

Full Changelog: pacocoursey/cmdk@v1.0.3...v1.0.4

v1.0.3

Compare Source

  • Fix use-sync-external-store shim for compatibility with Next.js 15 and React 19 RC

v1.0.2

Compare Source

  • Remove use-sync-external-store shim to support Next.js 15 and React 19 RC

Full Changelog: pacocoursey/cmdk@v1.0.1...v1.0.2

v1.0.1

Compare Source

What's Changed

New Contributors

Full Changelog: pacocoursey/cmdk@v1.0.0...v1.0.1

v1.0.0

Compare Source

This is a major version release as it contains breaking changes.

Breaking Changes

You will need to update your code to account for these changes before upgrading to cmdk@1.0.0.

value is now case sensitive 3dae25d

The value prop you pass to Command.Item and receive in onSelect is now case sensitive. But while the value is no longer lowercased, it is still trimmed.

Command.List is now required (CommandList in shadcn) 54aa261

Rendering the Command.List part (CommandList if using shadcn) is now mandatory. Otherwise, you should expect to see an error like this:

TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator))

The fix:

// Before
<Command label="Command Menu">
	<Command.Input />
	<Command.Item />
	{/* ... */}
</Command>
// After
<Command label="Command Menu">
	<Command.Input />

	<Command.List>
		<Command.Item />
		{/* ... */}
	</Command.List>
</Command>
Update [aria-disabled] and [aria-selected] CSS selectors c57e6b7

The aria-disabled and aria-selected props will now be set to false, instead of being undefined. If you previously used CSS selectors based on attribute presence, you will now need to use the attribute value.

/* Before */
[aria-disabled] {}
:not([aria-disabled]) {}

/* After */
[aria-disabled="true"] {}
[aria-disabled="false"] {}

What's Changed

New Contributors

Full Changelog: pacocoursey/cmdk@v0.2.1...v1.0.0

Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot force-pushed the renovate/cmdk-1.x branch 9 times, most recently from 5c2fe33 to c426576 Compare May 13, 2024 20:58
@renovate renovate bot force-pushed the renovate/cmdk-1.x branch 3 times, most recently from ccb40fe to 307300f Compare June 10, 2024 18:54
@renovate renovate bot force-pushed the renovate/cmdk-1.x branch 4 times, most recently from 79fdaa7 to b835c82 Compare July 8, 2024 07:53
@renovate renovate bot force-pushed the renovate/cmdk-1.x branch 2 times, most recently from 309e258 to dbdfd4c Compare July 22, 2024 05:59
@renovate renovate bot force-pushed the renovate/cmdk-1.x branch 2 times, most recently from b939c83 to d2931a2 Compare August 10, 2024 00:39
@renovate renovate bot force-pushed the renovate/cmdk-1.x branch 2 times, most recently from cde7393 to 2fc4073 Compare August 26, 2024 07:14
@renovate renovate bot force-pushed the renovate/cmdk-1.x branch 2 times, most recently from 29d586c to 19aaee3 Compare September 9, 2024 07:30
@renovate renovate bot force-pushed the renovate/cmdk-1.x branch 2 times, most recently from 88f4370 to a095f0d Compare September 23, 2024 04:02
@renovate renovate bot force-pushed the renovate/cmdk-1.x branch 3 times, most recently from 3410f06 to 31eebbf Compare October 7, 2024 04:23
@renovate renovate bot force-pushed the renovate/cmdk-1.x branch 2 times, most recently from 56e30c6 to 5156427 Compare October 14, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants