Code cleanup and add important metrics to log

NodeFactoryIo · Sep 23, 2020 · 18a4409 · 18a4409
1 parent 04cf4e0
commit 18a4409
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/internal/controllers/metrics.go b/internal/controllers/metrics.go
@@ -23,7 +23,6 @@ func (c ApiController) SaveMetricsHandler(w http.ResponseWriter, r *http.Request
 	if err != nil {
 		var mr *util.MalformedRequest
 		if errors.As(err, &mr) {
-			// malformed request error
 			log.Errorf("Malformed request error: %v", err)
 			http.Error(w, mr.Msg, mr.Status)
 		} else {
@@ -45,11 +44,15 @@ func (c ApiController) SaveMetricsHandler(w http.ResponseWriter, r *http.Request
 	})
 
 	if err != nil {
-		// error on saving in database
 		log.Errorf("Unable to save metrics for node %v to database, error: %v", requestContext.NodeId, err)
 		http.Error(w, http.StatusText(http.StatusInternalServerError), http.StatusInternalServerError)
 		return
 	}
 
-	log.Debugf("Node %s saved new metrics", requestContext.NodeId)
+	log.Debugf(
+		"Node %s saved new metrics { finalized_block_height: %d, best_block_height: %d }",
+		requestContext.NodeId,
+		metricsRequest.FinalizedBlockHeight,
+		metricsRequest.BestBlockHeight,
+		)
 }
diff --git a/internal/controllers/ping.go b/internal/controllers/ping.go
@@ -17,7 +17,6 @@ func (c ApiController) PingHandler(w http.ResponseWriter, r *http.Request) {
 	}
 	err := c.pingRepo.Save(&ping)
 	if err != nil {
-		// error on saving in database
 		log.Errorf("Unable to save ping %v to database, error: %v", ping, err)
 		http.Error(w, http.StatusText(http.StatusInternalServerError), http.StatusInternalServerError)
 		return

diff --git a/internal/controllers/register.go b/internal/controllers/register.go
@@ -29,7 +29,6 @@ func (c ApiController) RegisterHandler(w http.ResponseWriter, r *http.Request) {
 	if err != nil {
 		var mr *util.MalformedRequest
 		if errors.As(err, &mr) {
-			// malformed request error
 			log.Errorf("Malformed request error: %v", err)
 			http.Error(w, mr.Msg, mr.Status)
 		} else {
@@ -68,7 +67,6 @@ func (c ApiController) RegisterHandler(w http.ResponseWriter, r *http.Request) {
 	}
 	err = c.nodeRepo.Save(node)
 	if err != nil {
-		// error on saving in database
 		log.Errorf("Unable to save node %v to database, error: %v", node, err)
 		http.Error(w, http.StatusText(http.StatusInternalServerError), http.StatusInternalServerError)
 		return