Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing is node active check on new metrics #102

Merged
merged 2 commits into from
Oct 26, 2020

Conversation

MakMuftic
Copy link
Member

@MakMuftic MakMuftic commented Oct 26, 2020

Add check if the node is active before trying to add it to active nodes inside metrics handler

PR Checklist

  • I have run linter localy
  • I have run unit and integration tests locally
  • Rebased to master branch / merged master
  • Updated CHANGELOG.md

Changes

  • Add IsNodeActive function to node repo
  • Add check if the node is active before trying to add it to active nodes inside metrics handler

Issues

Closes #101

@MakMuftic MakMuftic changed the title Add IsNodeActive method to NodeRepo and check if node already in acti… Fix missing is node active check on new metrics Oct 26, 2020
@MakMuftic MakMuftic marked this pull request as ready for review October 26, 2020 13:35
@MakMuftic MakMuftic self-assigned this Oct 26, 2020
@MakMuftic MakMuftic merged commit 4880e8c into dev Oct 26, 2020
@MakMuftic MakMuftic deleted the mmuftic/fix-metric-controller branch October 26, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants