Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add target block metric #177

Merged
merged 6 commits into from
Jan 21, 2021
Merged

Add target block metric #177

merged 6 commits into from
Jan 21, 2021

Conversation

MakMuftic
Copy link
Member

@MakMuftic MakMuftic commented Jan 21, 2021 •
edited
Loading

Refactor metrics endpoint to reflect changes made on daemon side (see issue) and disable nodes that are not synced to become active

PR Checklist

  • I have run linter localy
  • I have run unit and integration tests locally
  • Rebased to master branch / merged master
  • Updated CHANGELOG.md

Changes

  • Change /metrics endpoint controller
  • Fix and expand tests

Issues

Closes #174

@MakMuftic MakMuftic changed the title Target block metric Add target block metric Jan 21, 2021
@MakMuftic MakMuftic marked this pull request as ready for review January 21, 2021 07:57
@mpetrunic mpetrunic merged commit da3cd39 into dev Jan 21, 2021
@mpetrunic mpetrunic deleted the mmuftic/target-block-metric branch January 21, 2021 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpetrun5 mpetrun5 mpetrun5 approved these changes

@mpetrunic mpetrunic Awaiting requested review from mpetrunic mpetrunic is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collect node target block metrics
3 participants
@MakMuftic @mpetrun5 @mpetrunic