Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade request display inside grafana dashboard #190

Merged
merged 4 commits into from
Jan 29, 2021
Merged

Upgrade request display inside grafana dashboard #190

merged 4 commits into from
Jan 29, 2021

Conversation

MakMuftic
Copy link
Member

@MakMuftic MakMuftic commented Jan 27, 2021 •
edited
Loading

Upgrade request display inside grafana (track rate and number of requests in interval for HTTP and WS)

Additionally, mute specific data copy error logs inside HTTP tunnel

PR Checklist

  • I have run linter localy
  • I have run unit and integration tests locally
  • Rebased to master branch / merged master
  • Updated CHANGELOG.md

Example

Issues

Closes #182

mpetrunic
mpetrunic previously approved these changes Jan 27, 2021
View reviewed changes
@MakMuftic
Copy link
Member Author

New dashboard look

image

TODO

  • there is still possibility that if the number of ws requests is for example 6 dashboard will show 5.5. This depends on the selected interval and few other things. I will try to resolve this later, as I think this is ok for now.

@MakMuftic MakMuftic marked this pull request as ready for review January 28, 2021 10:04
@MakMuftic MakMuftic requested a review from mpetrun5 as a code owner January 28, 2021 10:04
@MakMuftic
Copy link
Member Author

This PR also deals with this issue on vedran-daemon

@MakMuftic MakMuftic requested a review from mpetrunic January 28, 2021 10:09
@MakMuftic MakMuftic merged commit 1fe2b45 into dev Jan 29, 2021
@MakMuftic MakMuftic deleted the mmuftic/minor-upgrade branch January 29, 2021 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpetrunic mpetrunic mpetrunic approved these changes

@mpetrun5 mpetrun5 Awaiting requested review from mpetrun5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Grafana dashboard missing data
2 participants
@MakMuftic @mpetrunic