Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement whitelisting logic #29

Merged
merged 5 commits into from
Sep 22, 2020
Merged

Implement whitelisting logic #29

merged 5 commits into from
Sep 22, 2020

Conversation

MakMuftic
Copy link
Member

Changes

  • Implemented bucket that holds all whitelisted node IDs (populated on start)
  • Expanded register handler to check if node whitelisted (only if --whitelist flag set on start)

Issues

closes #7

@MakMuftic MakMuftic self-assigned this Sep 22, 2020
mpetrunic
mpetrunic approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@mpetrunic mpetrunic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think you've needed to store whitelisted in db but ok

@MakMuftic MakMuftic merged commit f8f053f into master Sep 22, 2020
@MakMuftic MakMuftic deleted the mmuftic/implement-whitelist branch September 22, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpetrunic mpetrunic mpetrunic approved these changes

@mpetrun5 mpetrun5 mpetrun5 approved these changes

Assignees

@MakMuftic MakMuftic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Register endpoint
3 participants
@MakMuftic @mpetrunic @mpetrun5