Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix register handler #83

Merged
merged 3 commits into from
Oct 22, 2020
Merged

Fix register handler #83

merged 3 commits into from
Oct 22, 2020

Conversation

MakMuftic
Copy link
Member

@MakMuftic MakMuftic commented Oct 22, 2020 •
edited
Loading

Refactor registration handler so if a node with a provided ID already registered only register response with the token is returned

PR Checklist

  • I have run linter localy
  • I have run unit and integration tests locally
  • Rebased to master branch / merged master
  • Updated CHANGELOG.md

Changes

  • Restructure register handler function
  • Fix failing tests and expand to cover problematic use case

Issues

Closes #79

@MakMuftic MakMuftic changed the title Refactor register handler Fix register handler Oct 22, 2020
@MakMuftic MakMuftic linked an issue Oct 22, 2020 that may be closed by this pull request
Fix register handler #79
Closed
mpetrun5
mpetrun5 previously approved these changes Oct 22, 2020
View reviewed changes
@MakMuftic MakMuftic self-assigned this Oct 22, 2020
@mpetrun5 mpetrun5 merged commit 34f47fe into dev Oct 22, 2020
@mpetrun5 mpetrun5 deleted the mmuftic/fix-register-handler branch October 26, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpetrunic mpetrunic mpetrunic approved these changes

@mpetrun5 mpetrun5 mpetrun5 left review comments

Assignees

@MakMuftic MakMuftic

Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix register handler
3 participants
@MakMuftic @mpetrunic @mpetrun5