Issue #512 send_command("monitoring") is doomed to fail #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since we have updated the testing suite would you mind adding tests for this now? Then we can get this merged. |
|
I'll try to find some time to work on it soon. |
|
I added a test case, and confirmed that, without the fix in place, the bug is triggered by the test case. With the fix in place, the test is passing. |
|
Thanks for adding tests. @bcoe @erinspice care to take a quick look? |
|
@danielbprice awesome contribution thank you! |
bcoe
added a commit
that referenced
this pull request
Aug 27, 2015
Issue #512 send_command("monitoring") is doomed to fail
|
Great! Thanks, @danielbprice! |
This was referenced Oct 17, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to work out how to add a test case for this condition but it was challenging since the current
tests don't really deal with disconnects/reconnects/etc. I have run some of my own tests with
this change in place and it seems to work but additional validation would be welcomed.