Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: output pushed images with digests #248

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Conversation

pl4nty
Copy link
Contributor

@pl4nty pl4nty commented Jul 9, 2023

Fixes #247. Adds an images output with comma-separated images including their digests.

The current package.json causes a runtime error, so I had to revert to 3b3592f. CI also needed changes to run on a fork (#249).

Successful CI: https://github.com/pl4nty/docker-manifest-action/actions/runs/5500272730/jobs/10023077440
Successful test for my usecase (cosign): https://github.com/pl4nty/containers/actions/runs/5500373420/jobs/10023244496

@pl4nty pl4nty requested a review from auguwu as a code owner July 9, 2023 14:17
@auguwu
Copy link
Member

auguwu commented Jul 15, 2023

Can you fix the merge conflicts and run yarn lint to make sure the ESLint CI doesn't error out?

@pl4nty pl4nty force-pushed the patch-1 branch 2 times, most recently from ee0671c to bc3b2c1 Compare July 16, 2023 01:28
@pl4nty
Copy link
Contributor Author

pl4nty commented Jul 16, 2023

Done

@pl4nty
Copy link
Contributor Author

pl4nty commented Jul 16, 2023

Scratch that - yarn lint passes, but CI fails due to yarn test

@pl4nty
Copy link
Contributor Author

pl4nty commented Jul 16, 2023

Fixed, CI is passing on the fork

Copy link
Member

@auguwu auguwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update ESLint since that should be fixed by now, but lgtm! 💜

@auguwu auguwu merged commit 1dfd9a1 into Noelware:master Jul 17, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output image digests
2 participants