Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Universal Angular #20

Merged
merged 2 commits into from
Jul 23, 2016
Merged

Fixes for Universal Angular #20

merged 2 commits into from
Jul 23, 2016

Conversation

threesquared
Copy link
Contributor

Inject DOCUMENT and remove HostListener decorator.

Inject `DOCUMENT` and remove `HostListener` decorator.
@Nolanus
Copy link
Owner

Nolanus commented Jul 20, 2016

Hi threesquared,

thanks for the PR. Is there any reason/source for favoring the "host" property in the directive annotation over the @HostListener annotation? I like it because this way the whole "interface" is at one place, just asking about caveats or consequences.

Sebastian

@threesquared
Copy link
Contributor Author

Hi Sebastian,

There is an issue with the Event global when running in angular universal. I copied the fix from here which goes into more detail.

Ben

@Nolanus Nolanus merged commit 1f457ec into Nolanus:master Jul 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants