refactor: requestAnimationFrame #420
Conversation
Migrating from setInterval to requestAnimationFrame for a more optimize animation
There was a problem hiding this comment.
Hi @NormanV41,
thank you very much for the PR. I only have two notes that have to be checked. Feel free to do that, otherwise I'll try to squeeze that into my schedule this week.
| } | ||
|
|
||
| }, this.config._interval, pageScrollInstance); |
There was a problem hiding this comment.
As the config _interval is not needed any longer to "customize" the animation/repaint, it should be removed
There was a problem hiding this comment.
I have deleted everything related with config._interval
| @@ -198,7 +198,14 @@ export class PageScrollService { | |||
| // .. and calculate the end time (when we need to finish at last) | |||
| pageScrollInstance.endTime = pageScrollInstance.startTime + pageScrollInstance.executionDuration; | |||
|
|
|||
| pageScrollInstance.timer = setInterval((instance: PageScrollInstance) => { | |||
| pageScrollInstance.requestFrameId = window.requestAnimationFrame(this.updateScrollPostion(pageScrollInstance)) | |||
There was a problem hiding this comment.
The global window object shouldn't be access directly, rather the little bit more complicated angular way via document object, that we already got hold of at the pageScrollInstance config
https://stackoverflow.com/a/50023378/2225619 , https://stackoverflow.com/a/52620181/2225619)
There was a problem hiding this comment.
You are right, I changed it, now I am using pageScrollInstance.pageScrollOptions.document.defalutView instead of window
Now use the injected document to reference the window object.
the _interval option is no longer needed
Migrating from setInterval to requestAnimationFrame for a more smooth animation