Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support point_evaluation_precompile when hardfork is cancun or later #364

Closed
dajuguan opened this issue Apr 6, 2024 · 4 comments · Fixed by NomicFoundation/hardhat#5100
Assignees
Milestone

Comments

@dajuguan
Copy link

dajuguan commented Apr 6, 2024

Describe the feature

https://github.com/ethereum/EIPs/blob/master/EIPS/eip-4844.md#point-evaluation-precompile

Search terms

point evaluation precompile, 4844, eip4844, eip-4844, kzg proof

@fvictorio fvictorio transferred this issue from NomicFoundation/hardhat Apr 8, 2024
@fvictorio fvictorio changed the title Support point_evaluation_precompile Support point_evaluation_precompile when hardfork is cancun or later Apr 8, 2024
@fvictorio fvictorio moved this from Backlog to To-do in Hardhat Apr 8, 2024
@fvictorio
Copy link
Member

fvictorio commented Apr 8, 2024

Thanks @dajuguan for reporting this.

Note for ourselves: a very minimal test is make an eth_call to 0x000000000000000000000000000000000000000a without any input data. Since the precompile checks that the input data is 192 bytes long, it should revert. Right now it doesn't.

We could also have a test it with a proper proof, but that would be like testing REVM itself, which I don't think makes sense.

@dajuguan
Copy link
Author

dajuguan commented Apr 8, 2024

Thanks @dajuguan for reporting this.

Note for ourselves: a very minimal test is make an eth_call to 0x000000000000000000000000000000000000000a without any input data. Since the precompile checks that the input data is 192 bytes long, it should revert. Right now it doesn't.

We could also have a test it with a proper proof, but that would be like testing REVM itself, which I don't think makes sense.

FYI, I've written a simple test case in js and python.

@fvictorio
Copy link
Member

Ah, that could be useful, thanks!

@Wodann Wodann self-assigned this Apr 9, 2024
@Wodann Wodann removed this from Hardhat Apr 9, 2024
@Wodann Wodann added this to EDR Apr 9, 2024
@Wodann Wodann added this to the EDR v0.3.5 milestone Apr 9, 2024
@github-project-automation github-project-automation bot moved this to Unconfirmed in EDR Apr 9, 2024
@Wodann Wodann moved this from Unconfirmed to Todo in EDR Apr 9, 2024
@Wodann Wodann moved this from Todo to In Progress in EDR Apr 9, 2024
@Wodann Wodann moved this from In Progress to Under Review in EDR Apr 10, 2024
@Wodann Wodann linked a pull request Apr 10, 2024 that will close this issue
2 tasks
@github-project-automation github-project-automation bot moved this from Under Review to Done in EDR Apr 15, 2024
@Wodann
Copy link
Member

Wodann commented Apr 16, 2024

We released EDR v0.3.5 with a fix for this issue.

If you’re using the latest Hardhat release, in order to use EDR v0.3.5, you can remove your node_modules directory and npm/yarn/pnpm lock file and reinstall your dependencies. You can verify that you’re using the correct version of EDR by running the following command:

npm ls @nomicfoundation/edr

It should print 0.3.5.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants