Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing KZG point evaluation precompile #5100

Merged
merged 6 commits into from
Apr 15, 2024
Merged

Conversation

Wodann
Copy link
Member

@Wodann Wodann commented Apr 10, 2024

In the process of fixing this, I also updated all Rust dependencies to ensure that we could use the latest version of revm (v8.0.0)

Depends on

@Wodann Wodann requested review from fvictorio and agostbiro April 10, 2024 13:14
@Wodann Wodann self-assigned this Apr 10, 2024
Copy link

changeset-bot bot commented Apr 10, 2024

🦋 Changeset detected

Latest commit: 5f46e74

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@nomicfoundation/edr Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 2:40pm

@Wodann Wodann temporarily deployed to github-action-benchmark April 10, 2024 13:14 — with GitHub Actions Inactive
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Apr 10, 2024
crates/edr_eth/src/transaction/signed.rs Outdated Show resolved Hide resolved
crates/edr_evm/src/mempool.rs Show resolved Hide resolved
crates/edr_provider/src/data.rs Show resolved Hide resolved
crates/edr_provider/src/test_utils.rs Show resolved Hide resolved
@agostbiro
Copy link
Member

Change request: it looks like there is a new transitive dependency that doesn't build on Windows.

@@ -20,7 +20,7 @@ reqwest = { version = "0.11", features = ["blocking", "json"] }
reqwest-middleware = { version = "0.2.4", default-features = false }
reqwest-retry = { version = "0.3.0", default-features = false }
reqwest-tracing = { version = "0.4.7", default-features = false, optional = true }
revm-primitives = { version = "3.0", default-features = false }
revm-primitives = { git = "https://github.com/Wodann/revm", rev = "451f122", version = "3.1", default-features = false, features = ["hashbrown"] }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: why are we using a fork again here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We upstreamed 2 changes to revm that:

  1. was merged but not released yet
  2. was not merged yet

crates/edr_evm/src/mempool.rs Show resolved Hide resolved
Copy link
Member

@agostbiro agostbiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM assuming CI passes.

@Wodann Wodann temporarily deployed to github-action-benchmark April 15, 2024 14:38 — with GitHub Actions Inactive
@Wodann Wodann linked an issue Apr 15, 2024 that may be closed by this pull request
@Wodann Wodann merged commit bbc3a6d into main Apr 15, 2024
41 checks passed
@Wodann Wodann deleted the edr/fix/full-block branch April 15, 2024 15:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area:edr status:ready This issue is ready to be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replay block failure: 19645342 Support point_evaluation_precompile when hardfork is cancun or later
3 participants