chore: js tooling improvements

.github/actions/setup-node/action.yml

@@ -0,0 +1,24 @@
+name: Setup node
+description: Sets up node and pnpm
+
+inputs:
+  pnpm-version:
+    description: Version of pnpm to install
+    required: false
+    default: "9"
+  node-version:
+    description: Version of node to install
+    required: false
+    default: "20"
+
+runs:
+  using: composite
+  steps:
+    - uses: pnpm/action-setup@v4
+      with:
+        version: ${{ inputs.pnpm-version }}
+    - uses: actions/setup-node@v4
+      id: setup-node
+      with:
+        node-version: ${{ inputs.node-version }}
+        cache: pnpm

.github/actions/setup-rust/action.yml

@@ -0,0 +1,13 @@
+name: Setup rust
+description: Sets up rust
+
+runs:
+  using: composite
+  steps:
+    - name: Install Rust (stable)
+      uses: actions-rs/toolchain@v1
+      with:
+        profile: minimal
+        override: true
+
+    - uses: Swatinem/rust-cache@v2

.github/workflows/edr-benchmark.yml

@@ -27,21 +27,8 @@ jobs:
     if: github.ref == 'refs/heads/main' || github.repository == github.event.pull_request.head.repo.full_name
     steps:
       - uses: actions/checkout@v3
-
-      - uses: pnpm/action-setup@v4
-        with:
-          version: 9
-      - name: Install Node
-        uses: actions/setup-node@v2
-        with:
-          node-version: 20
-          cache: pnpm
-
-      - name: Install Rust (stable)
-        uses: actions-rs/toolchain@v1
-        with:
-          profile: minimal
-          override: true
+      - uses: ./.github/actions/setup-node
+      - uses: ./.github/actions/setup-rust
 
       - name: Install package
         run: pnpm install --frozen-lockfile --prefer-offline

.github/workflows/edr-ci.yml

@@ -23,18 +23,11 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
-
-      - name: Install Rust (stable)
-        uses: actions-rs/toolchain@v1
-        with:
-          profile: minimal
-          override: true
+      - uses: ./.github/actions/setup-rust
 
       # Install pre-built binaries for cargo hack
       - uses: taiki-e/install-action@cargo-hack
 
-      - uses: Swatinem/rust-cache@v2
-
       - name: Cargo hack
         uses: actions-rs/cargo@v1
         with:
@@ -51,14 +44,7 @@ jobs:
         os: ["ubuntu-latest", "macos-latest", "windows-latest"]
     steps:
       - uses: actions/checkout@v3
-
-      - name: Install Rust (stable)
-        uses: actions-rs/toolchain@v1
-        with:
-          profile: minimal
-          override: true
-
-      - uses: Swatinem/rust-cache@v2
+      - uses: ./.github/actions/setup-rust
 
       - name: Cache EDR RPC cache
         uses: actions/cache@v2
@@ -145,55 +131,32 @@ jobs:
     needs: check-edr
     steps:
       - uses: actions/checkout@v3
-
-      - name: Install stable toolchain
-        uses: actions-rs/toolchain@v1
-        with:
-          profile: minimal
-          override: true
-
-      - uses: Swatinem/rust-cache@v2
+      - uses: ./.github/actions/setup-rust
 
       - name: Cargo doc
         uses: actions-rs/cargo@v1
         with:
           command: doc
           args: --workspace --no-deps --all-features
 
-  prettier:
+  lint:
     name: Run Prettier
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
-
-      - uses: pnpm/action-setup@v4
-        with:
-          version: 9
-      - name: Install Node
-        uses: actions/setup-node@v2
-        with:
-          node-version: ${{ matrix.node }}
-          cache: pnpm
+      - uses: ./.github/actions/setup-node
 
       - name: Install package
         run: pnpm install --frozen-lockfile --prefer-offline
-
-      - name: Run prettier
-        run: pnpm run prettier
+      - name: Run lint script
+        run: pnpm run lint
 
   edr-napi-typings-file:
     name: Check that edr_napi typings file is up to date
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
-      - uses: pnpm/action-setup@v4
-        with:
-          version: 9
-      - name: Install Node
-        uses: actions/setup-node@v2
-        with:
-          node-version: ${{ matrix.node }}
-          cache: pnpm
+      - uses: ./.github/actions/setup-node
 
       - name: Install package
         run: pnpm install --frozen-lockfile --prefer-offline

.github/workflows/edr-npm-release.yml

@@ -101,7 +101,7 @@ jobs:
         uses: actions/setup-node@v3
         if: ${{ !matrix.settings.docker }}
         with:
-          node-version: 18
+          node-version: 20
           check-latest: true
           cache: pnpm
       - name: Install Rust toolchain
@@ -174,15 +174,7 @@ jobs:
         working-directory: ./crates/edr_napi
     steps:
       - uses: actions/checkout@v4
-      - uses: pnpm/action-setup@v4
-        with:
-          version: 9
-      - name: Setup node
-        uses: actions/setup-node@v3
-        with:
-          node-version: ${{ matrix.node }}
-          check-latest: true
-          cache: pnpm
+      - uses: ./.github/actions/setup-node
       - name: Install dependencies
         run: pnpm install --frozen-lockfile --prefer-offline
       - name: Download artifacts
@@ -208,15 +200,7 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v4
-      - uses: pnpm/action-setup@v4
-        with:
-          version: 9
-      - name: Setup node
-        uses: actions/setup-node@v3
-        with:
-          node-version: ${{ matrix.node }}
-          check-latest: true
-          cache: pnpm
+      - uses: ./.github/actions/setup-node
       - name: Install dependencies
         run: pnpm install --frozen-lockfile --prefer-offline
       - name: Download artifacts
@@ -244,15 +228,9 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v4
-      - uses: pnpm/action-setup@v4
-        with:
-          version: 9
-      - name: Setup node
-        uses: actions/setup-node@v3
+      - uses: ./.github/actions/setup-node
         with:
           node-version: ${{ matrix.node }}
-          check-latest: true
-          cache: pnpm
       - name: Install dependencies
         run: |
           pnpm config set supportedArchitectures.libc "musl"
@@ -395,15 +373,7 @@ jobs:
         working-directory: ./crates/edr_napi
     steps:
       - uses: actions/checkout@v4
-      - uses: pnpm/action-setup@v4
-        with:
-          version: 9
-      - name: Setup node
-        uses: actions/setup-node@v3
-        with:
-          node-version: 18
-          check-latest: true
-          cache: pnpm
+      - uses: ./.github/actions/setup-node
       - name: Install dependencies
         run: pnpm install --frozen-lockfile --prefer-offline
       - name: Download all artifacts

.github/workflows/hardhat-tests.yml

@@ -16,27 +16,14 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: [18.15]
+        node: [20]
         os: ["macos-latest", "ubuntu-latest", "windows-latest"]
     steps:
       - uses: actions/checkout@v3
-
-      - uses: pnpm/action-setup@v4
-        with:
-          version: 9
-      - name: Install Node
-        uses: actions/setup-node@v2
+      - uses: ./.github/actions/setup-node
         with:
           node-version: ${{ matrix.node }}
-          cache: pnpm
-
-      - name: Install Rust (stable)
-        uses: actions-rs/toolchain@v1
-        with:
-          profile: minimal
-          override: true
-
-      - uses: Swatinem/rust-cache@v2
+      - uses: ./.github/actions/setup-rust
 
       - name: Install package
         run: pnpm install --frozen-lockfile --prefer-offline
@@ -55,9 +42,6 @@ jobs:
             hardhat-tests/test/internal/hardhat-network/stack-traces/test-files/artifacts
           key: hardhat-network-stack-traces-tests-${{ hashFiles('hardhat-tests/test/internal/hardhat-network/stack-traces/test-files/**/*.sol') }}-${{ hashFiles('hardhat-tests/test/internal/hardhat-network/stack-traces/test-files/**/test.json') }}-${{ hashFiles('hardhat-tests/test/internal/hardhat-network/stack-traces/**/*.ts') }}
 
-      - name: Build
-        run: cd hardhat-tests && pnpm build
-
       - name: Run tests
         env:
           INFURA_URL: ${{ secrets.INFURA_URL }}
@@ -72,15 +56,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
-
-      - uses: pnpm/action-setup@v4
-        with:
-          version: 9
-      - name: Install Node
-        uses: actions/setup-node@v2
-        with:
-          node-version: 18.15
-          cache: pnpm
+      - uses: ./.github/actions/setup-node
 
       - name: Install package
         run: pnpm install --frozen-lockfile --prefer-offline

.github/workflows/release.yml

@@ -19,16 +19,7 @@ jobs:
           # This makes Actions fetch all Git history so that Changesets can generate changelogs with the correct commits
           fetch-depth: 0
 
-      - name: Setup pnpm
-        uses: pnpm/action-setup@v4
-        with:
-          version: 9
-
-      - name: Setup Node.js 18.x
-        uses: actions/setup-node@v2
-        with:
-          node-version: 18.x
-          cache: "pnpm"
+      - uses: ./.github/actions/setup-node
 
       - name: Install Dependencies
         run: pnpm install --frozen-lockfile --prefer-offline

.github/workflows/test-recent-mainnet-block.yml

@@ -15,14 +15,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
-
-      - name: Install Rust (stable)
-        uses: actions-rs/toolchain@v1
-        with:
-          profile: minimal
-          override: true
-
-      - uses: Swatinem/rust-cache@v2
+      - uses: ./.github/actions/setup-rust
 
       - name: Cache EDR RPC cache
         uses: actions/cache@v2

.prettierrc.json

@@ -1,3 +1,4 @@
 {
-  "proseWrap": "never"
+  "proseWrap": "never",
+  "trailingComma": "es5"
 }

.syncpackrc.js

@@ -0,0 +1,22 @@
+// @ts-check
+
+/** @type {import("syncpack").RcFile} */
+const config = {
+  versionGroups: [
+    // smock only works with ethers v5
+    {
+      packages: ["hardhat-edr-smock-test"],
+      dependencies: ["ethers"],
+      // latest ethers v5 version
+      pinVersion: "5.7.2",
+    },
+  ],
+  semverGroups: [
+    {
+      dependencies: ["typescript"],
+      range: "~",
+    },
+  ],
+};
+
+module.exports = config;

crates/edr_napi/.eslintrc.js

@@ -0,0 +1,17 @@
+module.exports = {
+  extends: [`${__dirname}/../../config/eslint/eslintrc.js`],
+  parserOptions: {
+    project: `${__dirname}/tsconfig.json`,
+    sourceType: "module",
+  },
+  rules: {
+    "@typescript-eslint/restrict-template-expressions": "off",
+    "import/no-extraneous-dependencies": [
+      "error",
+      {
+        devDependencies: true,
+      },
+    ],
+    "prefer-template": "off",
+  },
+};