fix:complex calls

[kanej]

To allow m.call(...) calls against overloaded functions we now support the following syntax:

m.call(resolver, "setAddr(bytes32,address)", {
  args: [resolverNode, resolver],
});

Technical details

The invocation using the setAddr(bytes32,address) was fine, but failed the initial validation. This fix is to the validation code.

[zoeyTM]

LGTM

[fvictorio]

Repeating here what I said to John in the chat just for the record:

I think using the signature like this is fine, and that the alternative of trying to use the value of the args array to determine which overload to use seems super complex and it might have a lot of weird edge cases (or maybe not, but it's really hard to tell in advance).

[MatiFalcone]

I have the following module:

function createPoap(m: IgnitionModuleBuilder) {

  const proxyAdminOwner = m.getAccount(0);

  const name = m.getParameter('name');
  const symbol = m.getParameter('symbol');

  const poapContract = m.contract('Poap', [
    name,
    symbol,
    proxyAdminOwner
  ]);

  // Initialize
  const baseUri = m.getParameter('baseUri');
  m.call(poapContract, "initialize", [baseUri, []]);

  return { poapContract };
}

And I am getting this error:

Poap#Poap.initialize:
 - IGN710: Function 'initialize' is overloaded in contract Poap. Please use one of these names instead:

 - initialize()
 - initialize(string,address[])
 - initialize(address)

But when I changed it to the function I want to execute (initialize(string,address[])) I get:

IgnitionError: IGN702: Module validation failed with reason: The function name "initialize(string,address[])" is invalid, make sure you use a valid identifier.

How can I execute that function?

[kanej]

Can you paste a version of the Solidity code of your contract?

Are you able to invoke the initialize(address) version if you change the parameter list? To exclude the issue being a bug with Ignition dealing with address[] incorrectly.

[matias-gmg]

The version of Solidity I am using is 0.8.24 and when I call initialize(address) everything works as expected.

[matias-gmg]

@kanej based on this issue, it looks like there is a bug with Ignition dealing with any [] type.

[SyedAsadKazmi]

Kindly please see to it, @kanej. Thanks.