Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample project for upgradeable proxy usage #655

Merged
merged 10 commits into from
Jun 20, 2024

Conversation

zoeyTM
Copy link
Contributor

@zoeyTM zoeyTM commented Dec 14, 2023

resolves #641

@zoeyTM zoeyTM force-pushed the upgradeable-example-project branch 3 times, most recently from 3f2d446 to 920b149 Compare April 15, 2024 09:29
@jkirkpatrick
Copy link

jkirkpatrick commented Apr 16, 2024

OZ upgradable contracts should not accept constructor parameters... How should I pass parameters when using a custom initializer? How do you specify the initializer or upgrade functions, e.g. updateToAndCall?

@zoeyTM zoeyTM requested a review from alcuadrado June 17, 2024 06:40
@zoeyTM zoeyTM force-pushed the upgradeable-example-project branch from 548e0b3 to 40b0cff Compare June 17, 2024 15:39
@zoeyTM zoeyTM force-pushed the development branch 2 times, most recently from 6f5ec1c to 1675490 Compare June 17, 2024 16:50
@zoeyTM zoeyTM force-pushed the upgradeable-example-project branch from 40b0cff to dbc14fd Compare June 18, 2024 04:52
To deploy an example of a proxy contract being upgraded against the ephemeral Hardhat network:

```shell
npx hardhat ignition deploy ./ignition/modules/UpgradeModule.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I split these two calls apart @zoeyTM

Copy link
Member

@kanej kanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a run through locally.
I pushed a few changes, specifically:

  1. splitting up the commands in the readme
  2. including the example in the pnpm workspace (this commit)
  3. Removing unused variables in the test file

I think all that is left is to rebase on development and bump the version of the example to the latest 0.15.5.

@zoeyTM
Copy link
Contributor Author

zoeyTM commented Jun 20, 2024

@kanej merging because it's already rebased and it doesn't look like we update the versions of the example projects. We can update them later all at once if we want.

I also tried adding the ENS project to the workspace, but it's still bugged. I briefly tried to fix it, but it seems like a much more involved dive is needed and it's not worth the time right now.

@zoeyTM zoeyTM merged commit c4278b6 into development Jun 20, 2024
7 checks passed
@zoeyTM zoeyTM deleted the upgradeable-example-project branch June 20, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Provide sample project for open zeppelin upgrade contracts
5 participants