-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sample project for upgradeable proxy usage #655
Conversation
3a054cb
to
81f4b99
Compare
4bb4325
to
b749c75
Compare
3f2d446
to
920b149
Compare
OZ upgradable contracts should not accept constructor parameters... How should I pass parameters when using a custom initializer? How do you specify the initializer or upgrade functions, e.g. |
920b149
to
023d8cf
Compare
023d8cf
to
0922261
Compare
0922261
to
3f5fd18
Compare
548e0b3
to
40b0cff
Compare
6f5ec1c
to
1675490
Compare
40b0cff
to
dbc14fd
Compare
To deploy an example of a proxy contract being upgraded against the ephemeral Hardhat network: | ||
|
||
```shell | ||
npx hardhat ignition deploy ./ignition/modules/UpgradeModule.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I split these two calls apart @zoeyTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a run through locally.
I pushed a few changes, specifically:
- splitting up the commands in the readme
- including the example in the
pnpm
workspace (this commit) - Removing unused variables in the test file
I think all that is left is to rebase on development and bump the version of the example to the latest 0.15.5
.
@kanej merging because it's already rebased and it doesn't look like we update the versions of the example projects. We can update them later all at once if we want. I also tried adding the ENS project to the workspace, but it's still bugged. I briefly tried to fix it, but it seems like a much more involved dive is needed and it's not worth the time right now. |
resolves #641