Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify source code input for verification #712

Merged
merged 4 commits into from
Apr 2, 2024
Merged

Conversation

zoeyTM
Copy link
Contributor

@zoeyTM zoeyTM commented Mar 12, 2024

fixes #706

packages/core/src/verify.ts Outdated Show resolved Hide resolved
@alcuadrado
Copy link
Member

Something that we discussed on a call.

Let's add a flag includeUnderlatedContracts to the verification function that core exposes. By default it should be false. If true, we don't minify the solc input.

Then, in the plugin, we add a --include-unrelated-contracts flag to verify, which enables that flag.

If the verification fails and the flag wasn't on, then we recommend the users to retry with --include-unrelated-contracts.

Copy link
Member

@alcuadrado alcuadrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zoeyTM zoeyTM merged commit 4149ed2 into development Apr 2, 2024
6 checks passed
@zoeyTM zoeyTM deleted the fix/verify-input branch April 2, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

apply HH-verify input simplification
3 participants