Add function to encode a function call #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanej
reviewed
Jun 11, 2024
kanej
reviewed
Jun 11, 2024
kanej
reviewed
Jun 11, 2024
kanej
reviewed
Jun 11, 2024
kanej
reviewed
Jun 11, 2024
Looking at our other examples I don't know why they refer to `named library`, I am going to leave them and quietly shut the door behind me.
kanej
reviewed
Jun 11, 2024
kanej
reviewed
Jun 11, 2024
packages/core/src/internal/validation/futures/validateNamedEncodeFunctionCall.ts
Show resolved
Hide resolved
kanej
reviewed
Jun 11, 2024
packages/core/test/reconciliation/futures/reconcileNamedEncodeFunctionCall.ts
Outdated
Show resolved
Hide resolved
kanej
reviewed
Jun 11, 2024
packages/core/test/reconciliation/futures/reconcileNamedEncodeFunctionCall.ts
Outdated
Show resolved
Hide resolved
kanej
reviewed
Jun 11, 2024
kanej
reviewed
Jun 11, 2024
| }); | ||
| }); | ||
|
|
||
| it("should not validate a non-existant hardhat contract", async () => { |
There was a problem hiding this comment.
Is this not testing the m.contract validation?
There was a problem hiding this comment.
No, this validation (as well as the normal function call) has its own version of the check that this is testing.
That being said, this comment made me notice that I somehow forgot to swap the validation functions when I copied these tests from the normal function call tests, so I'll push a commit with that change.
kanej
reviewed
Jun 11, 2024
kanej
reviewed
Jun 11, 2024
packages/core/src/internal/execution/future-processor/helpers/future-resolvers.ts
Outdated
Show resolved
Hide resolved
kanej
reviewed
Jun 11, 2024
kanej
reviewed
Jun 11, 2024
packages/core/src/internal/reconciliation/helpers/reconcile-data.ts
Outdated
Show resolved
Hide resolved
kanej
requested changes
Jun 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #760