Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust regex to handle square brackets #774

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Adjust regex to handle square brackets #774

merged 3 commits into from
Jun 6, 2024

Commits on Jun 4, 2024

  1. adjust regex for function and event names

    @zoeyTM
    zoeyTM committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    eadaa8b View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. update regex

    @zoeyTM
    zoeyTM committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    2c34ad9 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. test: tweak to regex 

    The Solidity grammar suggests that the first character of an identifier must be
a letter.

It is arguable therefore, that we should do that for the args list, but I think
this increment in precision is enough.

See https://docs.soliditylang.org/en/v0.8.26/grammar.html#a4.SolidityLexer.Identifier
    @kanej
    kanej committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    4ac475e View commit details
    Browse the repository at this point in the history